Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-197355085
### ACS CI BVT Run
**Sumarry:**
Build Number 102
Hypervisor xenserver
NetworkType Advanced
Passed=104
Failed=13
Skipped=4
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-197247697
### ACS CI BVT Run
**Sumarry:**
Build Number 101
Hypervisor xenserver
NetworkType Advanced
Passed=104
Failed=10
Skipped=4
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-15813
Sorry for the false alarm here. I didn't dig deep enough initially. It
seems that the Jenkins slave is out of disk space which is resulting in errors.
---
If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-188861751
Thanks. I will dig a bit deeper and and see if I can figure out why the
failures are happening in jenkins.
---
If your project is set up for it, you can reply to
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-188860155
@swill those entries already exist.
That failure in Jenkins seems to be happening even before Feb. 24th
It seems that I do not have access to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-188855819
Do we need to add a resources file to the Jenkins box to provide
translations for these entries?
I believe this is the cause of the recent jenkins failure.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-188769689
merged to 4.7, and then forwarded to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1390
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-188708927
@rafaelweingartner go ahead, if you LGTM as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-188609151
@rafaelweingartner : I have tested all changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-188441817
@nitin-maharana have you tested everything? @DaanHoogland Can we merge
this? And then forward it to master
---
If your project is set up for it, you
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-184053093
@rafaelweingartner : Its already present in our code. It translates the
dictionary keys.
---
If your project is set up for it, you can reply to this email
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-184007356
@nitin-maharana,
Your changes LGTM.
I just noticed that function â_lâ, is that something we have created?
---
If your project is set up for
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1390
CLOUDSTACK-9267: String is not localized on create instance wizards.
Repro Steps:
==
1. Setup basic environments as normal.
2. Open a browser, go to Web Console.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-178507781
more explanation then code, but makes sense. mostly cosmatic: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-178660255
LGTM as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-178526046
There is one more localised issue in the project page, So instead of
creating a new one adding it to this PR only.
---
If your project is set up for it,
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-178522940
I thought of making a small explanation. But I follow this template while
making a PR so that it would be easy for committer to review very fast. Anyway
18 matches
Mail list logo