Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-220971211
Have opened #1559 against master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ProjectMoon closed the pull request at:
https://github.com/apache/cloudstack/pull/1406
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-216223321
@ProjectMoon open PR against 4.7, this enhancement is feature-ish; so I
would say open against master. Thanks
---
If your project is set up for it, you can reply to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-209531960
another one against 4.6. how should we be handling this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-209533528
Yes exactly, but the oldest supported branch right now is 4.7.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-209533275
The current workflow, as I understand it, is that the oldest supported
release branch is for bug fixes (which are then forward-merged), and any new
features go
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-196244657
Is this output from the new automated system, or were these manually run?
At first glance some of the failed tests don't seem related to this change
(some
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-196016501
### ACS CI BVT Run
**Sumarry:**
Build Number 88
Hypervisor xenserver
NetworkType Advanced
Passed=102
Failed=14
Skipped=4
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-196015439
### ACS CI BVT Run
**Sumarry:**
Build Number 90
Hypervisor xenserver
NetworkType Advanced
Passed=99
Failed=20
Skipped=4
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-195923676
### ACS CI BVT Run
**Sumarry:**
Build Number 88
Hypervisor xenserver
NetworkType Advanced
Passed=102
Failed=14
Skipped=4
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1406#discussion_r53150413
--- Diff:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java
---
@@ -92,7 +92,7 @@ public static VolumeObject
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1406#discussion_r53149620
--- Diff:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java
---
@@ -92,7 +92,7 @@ public static VolumeObject
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-184136033
@GabrielBrascher added CollectionUtils.isEmpty. Any ideas on unit
test-ability?
---
If your project is set up for it, you can reply to this email and have
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-182452345
Tests were performed using a running environment. Deploy a zone, then
delete the hosts in the zone and make sure there are no system VMs remaining.
Wait for
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-182247435
How have you been able to test this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user ProjectMoon opened a pull request:
https://github.com/apache/cloudstack/pull/1406
CLOUDSTACK-9280: Allow system VM volumes to be expunged if no system VMs
are remaining.
This pull request is our proposed fix for
https://issues.apache.org/jira/browse/CLOUDSTACK-9280. I
GitHub user ProjectMoon opened a pull request:
https://github.com/apache/cloudstack/pull/1405
CLOUDSTACK-9280: Allow system VM volumes to be expunged when there are no
system VMs remaining
This pull request is our proposed fix for
Github user ProjectMoon closed the pull request at:
https://github.com/apache/cloudstack/pull/1405
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1405#issuecomment-181465209
Wrong base branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
19 matches
Mail list logo
