Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-216305899
fair enough, LGTM
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-216244116
Hi @rhtyd since it uses "ls" to get a list of packages, if the directory or
.jar file does not exist it is no big deal. It will output a No such file or
directory
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-216225073
@Slair1 if dh ha jar is missing for example there is no db-ha deb package,
what happens?
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-215848580
Sorry, I missed the LGTMs. :) I will add this to my merge queue. Thanks
@kiwiflyer for following up.
---
If your project is set up for it, you can reply to this
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-215840094
2 x LGTMs and CI complete. This is Ready to Merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-215615141
That's ok, thanks!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-215614954
None of the failures above are related to this PR, they are all issues I
see periodically in my environment. All of the supported usage tests passed,
so CI has
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-215614748
### CI RESULTS
```
Tests Run: 103
Skipped: 0
Failed: 3
Errors: 2
```
**Summary of the problem(s):**
```
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-215551223
Running CI now. Will have results later tonight or tomorrow...
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-207155639
No problem. Ya it took me a couple pull requests to figure out how they
work. Thanks for taking the time to do this for me. :)
---
If your project is set up for
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-207150675
thanks @swill , it looks much better now, i needed the -f on the git push
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-207144084
Once you get your local branch setup correctly with the squashed commit,
you should be able to do a `push - f` to replace what is in the PR with what
you have
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-207141177
@swill thanks, that makes sense. I did it to my branch the first time, but
for some reason when i tried to save to here it just created two more commits.
i'll try
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-207101177
No one is allowed to push code to `apache/cloudstack`, you have to push it
to your fork where your PR is coming from. Does that make sense?
---
If your project is
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-207077724
@swill i seem to get an access denied when pushing my change:
C:\slair\Source\Github\cloudstack [pr/1433]> git push origin pr/1433 --force
remote: Permission
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-207062648
No worries. :) This should work:
https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-207038085
@swill , i apologize, but this is my first PR. I squashed it in Github
Desktop on my local copy and did a push, but it sees like it it just added
additional
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-207033442
I applied 1433 and then tried to apply 1409, but 1433 changes prevent the
later patch from matching previous lines. One or the other probably needs to
be based
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-206949345
@kiwiflyer they conflict in what sense? They change different lines of
code, so I don't expect git to have an issue with them. Can you clarify?
---
If your
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-206947587
@swill Just FYI that this PR conflicts with
https://github.com/apache/cloudstack/pull/1409#issuecomment-197771350.
They fix different issues, but the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-206946085
@Slair1 can you please squash your commits. I will get this into my CI
queue so we can get this merged... Thanks...
---
If your project is set up for it, you can
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-197768091
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-197845922
Tested patch on a 4.7.1 lab.
Prior to patch:
INFO [cloud.usage.UsageServer] (main:null) (logid:) UsageServer ready...
INFO
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-195575292
If anyone still has issues, i also had to make the change from this PR:
#1409
---
If your project is set up for it, you can reply to this email and have your
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-195572826
@kiwiflyer Very good point, let me make a different change here so it is
more generic!
---
If your project is set up for it, you can reply to this email and have
26 matches
Mail list logo
