Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1448#issuecomment-199522152
Thank you @GabrielBrascher. I am also getting my CI setup so I can get
tests running against these PRs, so I should be able to start validating this
stuff as well.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1448#issuecomment-199521289
@DaanHoogland @swill thank you for the concern. I agree with the need for
executing integration/functional tests to keep the code stable. Unfortunately,
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1448#issuecomment-199509482
With these major stripping out of unused code, we need to be very careful
that we do not introduce integration test issues. Can you please validate that
the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1448#issuecomment-199275394
Ok, that is somewhat comforting, however still a large integration test
suite should be run on this.
---
If your project is set up for it, you can reply to
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1448#issuecomment-199272015
@DaanHoogland the lack of test in some classes indeed is a problem.
However, these classes that I removed are not being used.
I used UCDetector
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1448#issuecomment-199209016
@GabrielBrascher removing unused code is good; less is more. These are API
calls and related stuff however. A large test set should be run and I am
surprised
