Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1460
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-218844975
I think this one is ready...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-218844537
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 2
Errors: 0
Duration: 9h 17m 35s
```
**Summary of the
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-217132104
Tested locally on Ubuntu Linux 16.04, had to install some build
dependencies as README suggests to get pyenv installed. LGTM
@swill ready for merge
---
If
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-216603725
I'll play with pyenv, jenv tomorrow and keep you posted
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-216573789
Since both Jenkins and Travis are green, I agree that we don't need to do
any further testing on this one.
I will give this a LGTM, can I get one more?
---
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-216564080
@rhtyd @DaanHoogland @swill I don't think any tests are necessary for this
PR. Would y'all mind reviewing for LGTM?
---
If your project is set up for it, you
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-216226297
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-210618704
@DaanHoogland I rebased against master, and Travis and Jenkins have gone
green. Looks like my branch was out of date.
---
If your project is set up for it, you
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-209822016
so it was a timeout:
```
[INFO] Apache CloudStack Plugin - Quota Service ... SUCCESS [
44.634 s]
[INFO] Apache CloudStack Framework -
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-209649764
@DaanHoogland I forced pushed which triggered both Travis and Jenkins to
rebuild PR. However, the Jenkins details link still yields a 404. Any
thoughts on how I
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-209265910
@jburwell please restart the jenkins run (force push/close re-open) The
logs have been deleted from jenkins.
---
If your project is set up for it, you can
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-209210558
@DaanHoogland I don't know how these changes could cause secondary storage
controller unit tests to break. Unfortunately, the Jenkins report link returns
a 404.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-205705013
@jburwell the failure is not in rat but in the unit tests for the secondary
storage controller project
---
If your project is set up for it, you can reply to
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-205228160
Jenkins has failed on RAT, but the report doesn't indicate the nature of
the problem. As an attempt to debug, I was unable to replicate the failure
locally
15 matches
Mail list logo
