Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/716
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/716#issuecomment-133758939
Will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/716#issuecomment-13354
@borisroman I suggest you close this PR and do all the refactor work in a
separate branch, as discussed. Thanks!
---
If your project is set up for it, you can
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/716#issuecomment-132643862
@borisroman If I run this `grep -r Ip4 *` I see many references to `Ip4`.
Isn't this going to be confusing to rename a part of it only? Or am I missing
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/716#issuecomment-132646596
@remibergsma You are correct. Those are all not related to the
AddressFormat enum. Of course all should be renamed, but doing so in 1 time
will also will not
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/716
Changed AddressFormat elements to reflect changes in IPv4 and IPv6 refactor.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
You can merge this pull request into a Git
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/716#issuecomment-132497888
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
