Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1191#issuecomment-209360865
We need to re-submit this on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user nnesic closed the pull request at:
https://github.com/apache/cloudstack/pull/1191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1191#discussion_r47435856
--- Diff:
server/test/org/apache/cloudstack/networkoffering/MockUsageEventEmitter.java ---
@@ -0,0 +1,134 @@
+package org.apache.cloudstack.netw
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1191#discussion_r47435795
--- Diff:
engine/components-api/src/com/cloud/event/UsageEventEmitterImpl.java ---
@@ -131,54 +127,55 @@ public static void publishUsageEvent(String
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1191#discussion_r47435785
--- Diff:
engine/components-api/src/com/cloud/event/UsageEventEmitterImpl.java ---
@@ -38,44 +34,37 @@
import com.cloud.event.dao.UsageEventDao
GitHub user nnesic opened a pull request:
https://github.com/apache/cloudstack/pull/1191
Changed UsageEventUtils to UsageEventEmitter and made it injectable
Refactored code to make the UsageEventEmitter injectable. Fixed unit tests
where required, but otherwise no changes in the log
