[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/809#issuecomment-216189432 @sanju1010 please rebase against latest master and push -f, update on status of your PR This is baremetal specific test, how do I test it; the resources/urls

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

Github user harikrishna-patnala commented on the pull request: https://github.com/apache/cloudstack/pull/809#issuecomment-161954435 I have not tested but did a code walk through. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/809#issuecomment-161982308 Sure Daan I will add . On Dec 4, 2015 7:58 PM, "Daan Hoogland" wrote: > @sanju1010 can you

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/809#issuecomment-161980229 @sanju1010 can you add a run output to the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/809#issuecomment-144332699 @sanju1010 makes sense and then of course a test report and -description is needed. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

Github user harikrishna-patnala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/809#discussion_r40658808 --- Diff: test/integration/smoke/test_baremetal.py --- @@ -0,0 +1,155 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/809#issuecomment-144028463 @DaanHoogland , this test requires hardware. So I can't add this as part of travis yaml. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

Github user harikrishna-patnala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/809#discussion_r39363075 --- Diff: tools/marvin/marvin/config/BareMetal.cfg --- @@ -0,0 +1,194 @@ +{ +"zones": [ +{ +"name":

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

Github user harikrishna-patnala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/809#discussion_r39362992 --- Diff: test/integration/smoke/test_baremetal.py --- @@ -0,0 +1,155 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

GitHub user sanju1010 opened a pull request: https://github.com/apache/cloudstack/pull/809 Changes made to DeployDataCenter to support Baremetal Basic Zone Creation 1. Made changes to deployDataCenter.py to support zone creation with Baremetal as the Hyeprvisor 2. Added test

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/809#issuecomment-139542841 @sanju1010 I had a look and didn't see you add your test to the travis yaml, is it included in the travis run? (if yes no need for any test report) --- If