Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1402
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1402#issuecomment-211916588
Thanks. Looks good now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1402#issuecomment-211818185
@alexandrelimassantana @swill Thanks guys, fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1402#issuecomment-211562114
@remibergsma can you review the functionality you expect. I think the
logic is wrong, and if it is not, then it is VERY misleading.
The code in question
Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/1402#issuecomment-201681267
@remibergsma can't you asking false instead of "false" ? If the function
accepts boolean values I think that it would be more efficient.
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1402#issuecomment-196143942
### ACS CI BVT Run
**Sumarry:**
Build Number 92
Hypervisor xenserver
NetworkType Advanced
Passed=103
Failed=15
Skipped=4
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1402#issuecomment-193872249
Since forceencaps is no by default, I think this is a fair change. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1402#discussion_r52102132
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -531,6 +531,8 @@ def configure_ipsec(self, obj):
file.addeq("
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1402
Check the existence of 'forceencap' parameter before use
Check the existence of 'forceencap' parameter before use.
Error seen:
```
Traceback (most recent call last):
