[GitHub] cloudstack pull request: Cloudstack 8279

2015-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/90 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] cloudstack pull request: Cloudstack 8279

2015-02-27 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/90#issuecomment-76482904 LGTM, good effort. I think the logic to check can be improved by doing a split+sort+search instead of contains but it's good enough to start using jdk 1.8! --- If y

[GitHub] cloudstack pull request: Cloudstack 8279

2015-02-27 Thread K0zka
GitHub user K0zka opened a pull request: https://github.com/apache/cloudstack/pull/90 Cloudstack 8279 Fixes for [CLOUDSTACK-8279](https://issues.apache.org/jira/browse/CLOUDSTACK-8279) and two minor cleanups You can merge this pull request into a Git repository by running: $