Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1533
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-221162872
Yes, ready now. Thank you. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user sverrirab commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-221026255
everything looking good now it seems - time to merge @swill ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-220810862
This is coming back clean. Would you mind trying to rebase and re-push or
close and reopen to see if we can kick off travis one more time. Thanks...
---
If your pr
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-220810829
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 8h 55m 29s
```
**Associ
Github user sverrirab commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-220644228
Rebased the PR to latest master and reverted the relevant commit
(64b72a5c5a410f41bd869cc9d40807d888e05055.). I think we should be good to go
@swill ?
---
If y
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-220633650
@sverrirab thank you. Would you mind adding the revert of #1495 into this
commit in order to clean up unnecessary packages once this PR is accepted? I
think we are
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-220583491
Thanks! code-wise this looks good to me now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user sverrirab commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-219751032
@wido I just pushed an update that addresses the comments from @jburwell
tested this locally as well of course
---
If your project is set up for it, you
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-218761324
Can @sverrirab look at the comments of @jburwell ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-217569401
Sorry Will, Yes all passed, some after retest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-217567369
I am missing some code review on this one, but otherwise this is looking
good so far.
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-217566881
@DaanHoogland can you post a 'summary' of the results when you post this.
I don't want to have to download each of these files to know that they ran
successfully. C
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-217560805
I hadn't looked into the code yet so for what it's worth and pending
response to the comments:
CI RESULTS
[1533.results.internal_lb.txt](https://github
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1533#discussion_r62329185
--- Diff: scripts/vm/hypervisor/kvm/test_patchviasocket.py ---
@@ -0,0 +1,142 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Founda
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1533#discussion_r62328978
--- Diff: scripts/vm/hypervisor/kvm/test_patchviasocket.py ---
@@ -0,0 +1,142 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Founda
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1533#discussion_r62328994
--- Diff: scripts/vm/hypervisor/kvm/test_patchviasocket.py ---
@@ -0,0 +1,142 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Founda
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1533#discussion_r62328643
--- Diff: scripts/vm/hypervisor/kvm/test_patchviasocket.py ---
@@ -0,0 +1,142 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Founda
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1533#discussion_r62328413
--- Diff: scripts/vm/hypervisor/kvm/patchviasocket.py ---
@@ -0,0 +1,80 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1533#discussion_r62328214
--- Diff: scripts/vm/hypervisor/kvm/patchviasocket.py ---
@@ -0,0 +1,80 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (
Github user sverrirab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1533#discussion_r62309904
--- Diff: scripts/vm/hypervisor/kvm/patchviasocket.py ---
@@ -0,0 +1,80 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-217011034
Thanks for this! In the future I'd like to see this done through the Qemu
Guest Agent, but that is still waiting for something, see: #985
---
If your project is set u
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1533#discussion_r62118856
--- Diff: scripts/vm/hypervisor/kvm/patchviasocket.py ---
@@ -0,0 +1,80 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF)
GitHub user sverrirab opened a pull request:
https://github.com/apache/cloudstack/pull/1533
Convert patchviasocket to python (removes perl dependency for KVM agent)
As requested here: https://github.com/apache/cloudstack/pull/1495
No scripts are using perl so that install re
24 matches
Mail list logo
