Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/910#issuecomment-152054216
remote branch broken. closing this PR...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user pdion891 closed the pull request at:
https://github.com/apache/cloudstack/pull/910
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/910#discussion_r41616136
--- Diff: tools/docker/Dockerfile.centos6 ---
@@ -23,15 +23,19 @@ LABEL Vendor="Apache.org" License="ApacheV2"
Version="4.6.0"
ENV
PKG_URL=htt
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/910#discussion_r41171193
--- Diff: tools/docker/Dockerfile.centos6 ---
@@ -23,15 +23,19 @@ LABEL Vendor="Apache.org" License="ApacheV2"
Version="4.6.0"
ENV
PKG_URL=http://jen
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/910#discussion_r41171391
--- Diff: tools/docker/init.sh_centos6 ---
@@ -17,27 +17,35 @@
# under the License.
#
# update database connection
+# /usr/bin/cloudstack
Github user terbolous commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/910#discussion_r41142674
--- Diff: tools/docker/init.sh_centos6 ---
@@ -17,27 +17,35 @@
# under the License.
#
# update database connection
+# /usr/bin/cloudst
Github user pdion891 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/910#discussion_r41133343
--- Diff: tools/docker/Dockerfile.centos6 ---
@@ -23,15 +23,19 @@ LABEL Vendor="Apache.org" License="ApacheV2"
Version="4.6.0"
ENV
PKG_URL=http://j
Github user terbolous commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/910#discussion_r41121330
--- Diff: tools/docker/Dockerfile.centos6 ---
@@ -23,15 +23,19 @@ LABEL Vendor="Apache.org" License="ApacheV2"
Version="4.6.0"
ENV
PKG_URL=http://
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/910#discussion_r41120457
--- Diff: tools/docker/Dockerfile.centos6 ---
@@ -23,15 +23,19 @@ LABEL Vendor="Apache.org" License="ApacheV2"
Version="4.6.0"
ENV
PKG_URL=http://jen
Github user terbolous commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/910#discussion_r41120279
--- Diff: tools/docker/Dockerfile.centos6 ---
@@ -23,15 +23,19 @@ LABEL Vendor="Apache.org" License="ApacheV2"
Version="4.6.0"
ENV
PKG_URL=http://
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/910#issuecomment-145461959
aside of the vhd-util download, +1 LGTM based on code review.
Does not impact cloudstack core
---
If your project is set up for it, you can reply to this email an
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/910#discussion_r41119897
--- Diff: tools/docker/Dockerfile.centos6 ---
@@ -23,15 +23,19 @@ LABEL Vendor="Apache.org" License="ApacheV2"
Version="4.6.0"
ENV
PKG_URL=http://jen
GitHub user pdion891 opened a pull request:
https://github.com/apache/cloudstack/pull/910
Dockerfile part2
This PR simplify download of systemvm templates, work with docker-compose
and enable integration-api port and use of localstorage without reconfiguration
of cloudstack.
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/605#issuecomment-124988512
closing this, another PR in progress from another branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user pdion891 closed the pull request at:
https://github.com/apache/cloudstack/pull/605
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user pdion891 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/605#discussion_r35436991
--- Diff: tools/docker/Dockerfile.marvin ---
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/605#issuecomment-124565789
@DaanHoogland ( cc/ @pdion891 @wido ), this one is not Java so I am
comfortable reviewing it. The bottom line is that I don't review the 33 commits
I review the final
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/605#discussion_r35435993
--- Diff: tools/docker/Dockerfile.marvin ---
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor l
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/605#issuecomment-124282315
I'll squash, I've been told it was better for code review many small
commits than one big fat ass commit that nobody want to understand.
---
If your project is set
Github user pdion891 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/605#discussion_r35387474
--- Diff: tools/docker/Dockerfile.marvin ---
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/605#issuecomment-124263885
come on guys, if this is what happened this is what we have got. Squash wht
is not atomic and nothing else.
---
If your project is set up for it, you can reply
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/605#issuecomment-124246163
LGTM, but as @runseb says, please squash this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/605#issuecomment-123779835
LGTM if you address my couple comments.
And really, I would squash this (33 commits), I don't see why we need to
keep all those tiny commits in our master branch.
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/605#discussion_r35232136
--- Diff: tools/docker/Dockerfile.centos6 ---
@@ -0,0 +1,60 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/605#discussion_r35232181
--- Diff: tools/docker/README.md ---
@@ -0,0 +1,66 @@
+
+# Docker Files
+
+Dockerfiles used to build CloudStack images available on Docker h
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/605#discussion_r35232143
--- Diff: tools/docker/Dockerfile.marvin ---
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor l
GitHub user pdion891 opened a pull request:
https://github.com/apache/cloudstack/pull/605
Dockerfile
Initial PR for Dockerization of CloudStack.
Important Changes:
* scripts/vm/systemvm/injectkeys.sh: script execution will pass event if
/dev/loop0 not detected and wi
27 matches
Mail list logo
