Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220987228
ping @swill tag:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220986821
Changed db.x.path to db.x.driver as @DaanHoogland suggested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220983955
LGTM though it remains kluncy to some extend I think this is a considerable
improvement over what we had
---
If your project is set up for it, you can reply t
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64223844
--- Diff: client/tomcatconf/db.properties.in ---
@@ -25,6 +25,7 @@ region.id=1
db.cloud.username=@DBUSER@
db.cloud.password=@DBPW@
db.
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64223798
--- Diff: engine/storage/snapshot/test/resources/db.properties ---
@@ -46,6 +47,8 @@
db.cloud.url.params=prepStmtCacheSize=517&cachePrepStmts=true&prepSt
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64223758
--- Diff: build/replace.properties ---
@@ -21,6 +21,7 @@ DBROOTPW=
MSLOG=vmops.log
APISERVERLOG=api.log
DBHOST=localhost
+DBPATH=j
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64223544
--- Diff: engine/storage/snapshot/test/resources/db.properties ---
@@ -46,6 +47,8 @@
db.cloud.url.params=prepStmtCacheSize=517&cachePrepStmts=true&p
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220976080
@nlivens supakoel
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220974849
@DaanHoogland, I've added the piece we were talking about, this can be
found it the logs regarding loading the driver dynamically :
> 2016-05-23 05:42:57,880 DEB
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64195563
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
dbProps) {
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64193717
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
dbProps
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64191953
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
dbProps) {
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64179203
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
dbProps
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64178488
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
dbProps) {
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1553#discussion_r64040574
--- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java ---
@@ -1014,6 +1014,13 @@ public static void initDataSource(Properties
dbProps
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220599141
@DaanHoogland, triggering you for review as well, this is only a small code
change
---
If your project is set up for it, you can reply to this email and have your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220547372
LGTM, I am aware about the issue and the changes are therefore needed.
Thanks @nlivens
---
If your project is set up for it, you can reply to this email and have yo
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-220546975
@swill, @rhtyd, @kiwiflyer, triggering you guys because you were part of
this mailing thread.
---
If your project is set up for it, you can reply to this email and
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1553
Explicitely load JDBC driver before creating our MySQL connections
Solution to the mailing thread titled "MySQL : No suitable driver found for
jdbc:mysql".
It doesn't harm that we explicite
19 matches
Mail list logo
