[GitHub] cloudstack pull request: Factor in inaccurancy of System.nanoTime ...

2016-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1324 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Factor in inaccurancy of System.nanoTime ...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1324#issuecomment-170385290 validating by compile: ``` [INFO] [INFO] BUILD SUCCESS [INFO]

[GitHub] cloudstack pull request: Factor in inaccurancy of System.nanoTime ...

2016-01-10 Thread cristofolini
Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/1324#issuecomment-170381531 I've had tests involving sleep calls fail on me seemingly arbitrarily, to the point where simply re-running them would give me a passing result. I think someth

[GitHub] cloudstack pull request: Factor in inaccurancy of System.nanoTime ...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1324#issuecomment-170354023 makes sense. I doubt, this will do but it will reduce the chance of failure. It will not produce false negatives beyond the specified precision margin of the f

[GitHub] cloudstack pull request: Factor in inaccurancy of System.nanoTime ...

2016-01-08 Thread bheuvel
GitHub user bheuvel opened a pull request: https://github.com/apache/cloudstack/pull/1324 Factor in inaccurancy of System.nanoTime in class Profiler The time diff measurement by the class Profiler, is done by System.nanoTime(). System.nanoTime() is not 100% accurate (lots of inf