Re: [GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread Remi Bergsma
Looks like asfgit only closes PRs when we commit to master branch and not to any another one. Can we maybe ask for some more branches to be monitored, like 4.4 and 4.5 etc. Would save manual work. Regards, Remi Sent from my iPhone > On 29 May 2015, at 21:01, bhaisaab wrote: > > Github user

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106908889 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
Github user rsafonseca closed the pull request at: https://github.com/apache/cloudstack/pull/329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
Github user rsafonseca closed the pull request at: https://github.com/apache/cloudstack/pull/329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
GitHub user rsafonseca reopened a pull request: https://github.com/apache/cloudstack/pull/329 Fix agent/management conflict There is an entry for the agent log directory in the management packaging, creating a conflict between the two RPMs. This issue occurs in both 4.4.x and 4.

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106908778 @bhaisaab you are right! .. though it happened on the 4.5 version i built locally... perhaps my copy of the branch was not up to date when i tested :) Closing!

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106904206 @rsafonseca not applicable latest 4.5; applied your PR on 4.4. Thanks, please close it manually (asfgit failed to close it). --- If your project is set up for it,

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106904018 perhaps there was a regression? I got the issue in 4.4 and 4.5 master is fine though :) --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106903590 @rsafonseca this is not an issue on 4.5/master, I had already fixed it. possibly for 4.4; will apply it on 4.4 nonetheless. @DaanHoogland no need of another RC, it'

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106897613 nah not blocking a thing on my side.. just thought i'd contribute something more to your release, but it wasn't on time :) one old bug less for 4.4.5 i guess ;

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106894818 @rsafonseca , just a second or so, sorry. If this is really blocking you I can create a new RC on monday. It is an old known bug, though. Can't really worry to

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106893942 @DaanHoogland too late for 4.4.4? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/329 Fix agent/management conflict There is an entry for the agent log directory in the management packaging, creating a conflict between the two RPMs. This issue occurs in both 4.4.x and 4.5.