[GitHub] cloudstack pull request: Fix dockerbuild because hardcoded filenam...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/893#issuecomment-144046791 LGTM Based on code review. Not tested against a real environment. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: [GitHub] cloudstack pull request: Fix dockerbuild because hardcoded filenam...

Hi, Can someone LGTM this PR ? or we don't need the 2 LGTM as it's not on master? This fix the build of cloudstack simulator docker container of 4.5.x Thanks On Sun, Sep 27, 2015 at 8:57 PM, pdion891 wrote: > GitHub user pdion891 opened a pull request: > >

[GitHub] cloudstack pull request: Fix dockerbuild because hardcoded filenam...

Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/893#issuecomment-144051603 Thanks Guys! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Fix dockerbuild because hardcoded filenam...

Github user pdion891 closed the pull request at: https://github.com/apache/cloudstack/pull/893 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Fix dockerbuild because hardcoded filenam...

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/893#issuecomment-144048504 LGTM based on code review (1 line removed, 2 lines added). This does not change cloudstack code, the Dockerfile is only used by the docker hub to build the

[GitHub] cloudstack pull request: Fix dockerbuild because hardcoded filenam...

GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack/pull/893 Fix dockerbuild because hardcoded filename for marvin This fix docker simulator build of latest 4.5.x. This PR only go in 4.5 branch. Thanks You can merge this pull request