Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155383672
@wilderrodrigues Please see attachment
---
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155375779
@ustcweizhou and what about the ACL button?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155352944
@remibergsma @karuturi
For the isolated network and shared network, the guest NIC of VR is listed
at the top of NIC tab.
However, for VPC VR, the guest
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155386360
Thanks, @ustcweizhou ... this PR LGTM :+1:
@remibergsma, I believe it's ready to be merged.
Cheers,
Wilder
---
If your project is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1034
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155389974
Thanks @ustcweizhou LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155152303
Ping @remibergsma @ustcweizhou
1. Deployed a DC with a KVM host
2. Created 1 VM under an Isolated Network
3. Create a single VPC with 1
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155153401
@wilderrodrigues did you remove the .gz files?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155129605
Ping @ustcweizhou @remibergsma
Deploying DC with this PR now. Will submit tests in a moment.
Cheers,
Wilder
---
If your project is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155309530
[UI] fix typo for user data field - verfied
verified password dialog change
[UI] Network names are not being displayed in Infra » VRs » router »
NICS -
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1034#discussion_r44337756
--- Diff: server/src/com/cloud/api/query/dao/DomainRouterJoinDaoImpl.java
---
@@ -219,6 +219,7 @@ public DomainRouterResponse
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155005958
Based on the code a LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1034#discussion_r44254960
--- Diff: ui/scripts/vpc.js ---
@@ -1507,7 +1507,9 @@
},
complete: function(args) {
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1034
Fix some small UI bugs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ustcweizhou/cloudstack ui-changes
Alternatively you can review
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1034#discussion_r44015311
--- Diff: ui/scripts/vpc.js ---
@@ -4184,7 +4184,7 @@
// Get VPN gateways
$.ajax({
-
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-154048544
+1 LGTM, just looked at the code, did not check the actual UI rendering.
---
If your project is set up for it, you can reply to this email and have your
reply
16 matches
Mail list logo
