Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/630#issuecomment-131671852
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/630#issuecomment-131220146
I am alright with this. I was curious if @mike-tutkowski is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/630#issuecomment-131210799
@manuiiit Could you squash the commits as they have no value as separate
commits.
@mike-tutkowski @DaanHoogland Let me double check.. you both say LGTM
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/630#issuecomment-130696363
@mike-tutkowski LGTM if LGTY
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user manuiiit commented on the pull request:
https://github.com/apache/cloudstack/pull/630#issuecomment-128614235
@mike-tutkowski I understood what u said.Updated.Will keep it in mind from
next time.Thanks :) .
---
If your project is set up for it, you can reply to this email
Github user manuiiit commented on the pull request:
https://github.com/apache/cloudstack/pull/630#issuecomment-128602113
@mike-tutkowski I did not find any other possibility where
createPhysicalDisk would return null unless is called from
NfsManagedStorageAdaptor class.Please
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/630#issuecomment-128604281
That is very well true, but I worry that a comment that specific would
not be updated should the time come when another adaptor does, in fact, return
null
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/630#issuecomment-125874159
@manuiiit your change has checkstyle error, can you look at these? (at
least I see tabs instead of spaces)
---
If your project is set up for it, you can reply
GitHub user manuiiit opened a pull request:
https://github.com/apache/cloudstack/pull/630
Fixed Coverity issue Dereference null return value
Fixed Coverity issue Dereference null return value
You can merge this pull request into a Git repository by running:
$ git pull
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/620#issuecomment-124996034
this one can be close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/620
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user manuiiit opened a pull request:
https://github.com/apache/cloudstack/pull/620
Fixed Coverity issue Dereference null return value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuiiit/cloudstack master
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/620#issuecomment-124323473
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/620#issuecomment-124191945
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
15 matches
Mail list logo
