Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-177281584
Thanks @bhaisaab !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/969
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-175674716
LGTM
Merging based on comments, test results shared and 2+LGTMs
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-172391494
@DaanHoogland I see... Well, thanks for your effort on helping in this PR.
:)
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-172182133
No, these are disposible test enviroments. They are at two different
companies (Schuberg Philis and Leasweb) but as the test code has no relation to
the change
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-171944009
so it was env:
[969.network.results.txt](https://github.com/apache/cloudstack/files/91794/969.network.results.txt)
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-172028230
Hmmm, interesting... Did you know what exactly was causing that error?
@DaanHoogland
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-171274511
ok, i am convinced. it has nothing to do with the code at hand. I will
rerun the intergration to be sure but if I don't come back here: LGTM
---
If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-171553618
I am afraid the error is persistent and in two environments. I will have a
look if I see the same behaiavure with other PRs
---
If your project is set up for
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-171442487
Thanks @DaanHoogland !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-170541020
One failure. I am yet to investigat if it is related. will try and find
time soon.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-170620697
@DaanHoogland the problem seems to be related to something else.
It seemed more like a DNS problem to resolve the google.com address
---
If your
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-170626131
I agree with @rafaelweingartner, since we can check that in last lines.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-170340253
sorry @rodrigo93 it got squashed between all the work we did during the
last releases. I'll start it again.
---
If your project is set up for it, you can
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-170379092
That's ok @DaanHoogland, don't need to hurry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-170387660
it zooming. I think it passes all the way but I made a booboo on the test
scripts running an old version. will report tomorow morning, @rodrigo93 .
---
If
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-170394300
Alright @DaanHoogland. Thanks for the help! =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-170073320
Hello everyone. Sorry to bother you but, how are the tests going?
Is there anything else that I can do?
---
If your project is set up for it, you can reply to
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-161920931
LGTM, will start a regression suite
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-160300884
@DaanHoogland problem fixed ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-160288187
@rafaelweingartner @rodrigo93 I see more changes then needed in the diff.
Are there proper line endings in the files? this is a usual problem in those
cases.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-160288436
My bad, I did not waited till the Maven fixed all of projects configuration.
I will fix that.
---
If your project is set up for it, you can reply to
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-160287795
@remibergsma I have rebased and squashed the commits for @rodrigo93
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-160323830
Hi guys.
Sorry for the delay. Thank you all for helping me out. I had some personal
problems.
My bad.
Thanks once again! I hope this commit will help
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-158792594
Hi @remibergsma. I am trying to fix it to put all in one commit. I have
force pushed already, but it seems that it does no work. I have tried to squash
them, but
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-158673227
Hi @rodrigo93 Thanks for rebasing, but please make sure you have one commit
(and get rid of the merge commit). Thanks!
---
If your project is set up for it,
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-158671871
Just to update, I merged the commit with master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-153684531
LGTM (code, no testing performed)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rodrigo93 closed the pull request at:
https://github.com/apache/cloudstack/pull/969
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user rodrigo93 reopened a pull request:
https://github.com/apache/cloudstack/pull/969
Fixed return type Void to void in DataMotionStrategy.
The main changes are:
- Changing methods âVoidâ to âvoidâ.
- Removal of the method âVoid copyAsync(DataObject
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-151204587
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-150967148
Hi @rodrigo93 can you please rebase against current master? Then I can run
soms tests. Thanks!
---
If your project is set up for it, you can reply to this
GitHub user rodrigo93 opened a pull request:
https://github.com/apache/cloudstack/pull/969
Fixed return type Void to void in DataMotionStrategy.
The main changes are:
- Changing methods âVoidâ to âvoidâ.
- Removal of the method âVoid copyAsync(DataObject
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/854
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/854#issuecomment-141713041
@rodrigo93 nice commit.
Could you squash your commits?
Here is a link, if you do not know how to do that.
GitHub user rodrigo93 opened a pull request:
https://github.com/apache/cloudstack/pull/854
Fixed return type Void to void in DataMotionStrategy.
The main changes are:
- Changing methods âVoidâ to âvoidâ.
- Removal of the method âVoid copyAsync(DataObject
36 matches
Mail list logo
