[GitHub] cloudstack pull request: Git PR merge script improvements

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/734 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134350634 Verified that it now works on my weird URL as well. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134215959 @terbolous Squashed the latest fix into an earlier commit, as that makes more sense. If you want to see the diff that should fix your issue, look here: https://g

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134198135 @terbolous Hmm, the default always includes .git in the end (both for https and ssh). Although, as you said, omitting the .git part works (in both cases). Just s

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134174620 @terbolous Ah, I see your point now ;-) Thanks, I will make it work. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134167474 @remibergsma it does point to the apache repo, but with a somewhat different url I used 'git clone gh:apache/cloudstack' to initialize the repo, and that

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134165993 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134165204 @terbolous You need to point to the Apache mirror on GitHub, not your fork. The PRs are at the mirror repository. Also, the version from this PR gives more descr

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134163621 On the other side, if you just drop the '.git' suffix, you risk matching things like 'cloudstack-docs-rn' while you really mean 'cloudstack' --- If your project i

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134163369 Might not be related as this is the first time I try the script, but I'm getting this: eriweb@eriweb:~/git/cloudstack/tools/git master$ git pr 735 --force W

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134160535 tested with a cloudstack-docs-admin PR and a cloudstack PR. worked great. Thanks for the update. :+1: --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: Git PR merge script improvements

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/734 Git PR merge script improvements Processed feedback from @bhaisaab and (a colleague of) @karuturi - make the help message better (I also updated Confluence) - make sure we can u