[GitHub] cloudstack pull request: Implement a NSX API request execution cou...

2016-01-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1294 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Implement a NSX API request execution cou...

2016-01-18 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1294#issuecomment-172505055 LGTM :+1: Did code review and ran the PR in beta --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Implement a NSX API request execution cou...

2016-01-18 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1294#issuecomment-172460540 @remibergsma @DaanHoogland I've fixed a concurency issue in a unit tests (pointed out by @borisroman) and in the process rebased this branch on latest 4.7.

[GitHub] cloudstack pull request: Implement a NSX API request execution cou...

2016-01-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1294#issuecomment-172375026 makes sense @miguelaferreira . I have no use to this but I think it needs to go in LGTM @remibergsma --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Implement a NSX API request execution cou...

2016-01-17 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1294#issuecomment-172309823 @borisroman said he had an improvement to the unit test. Let's discuss and add it to the PR so we can merge it. --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: Implement a NSX API request execution cou...

2016-01-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1294#issuecomment-172247247 Haven't seen the issue in our production cloud since we run with this fix. Thanks! LGTM. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Implement a NSX API request execution cou...

2015-12-28 Thread miguelaferreira
GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/1294 Implement a NSX API request execution counter per thread The NSX plugin has a execution counter to prevent infinite recursion (and as a result a stack overflow exception). However, the