[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

2016-03-28 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1285#issuecomment-202347507 ### ACS CI BVT Run **Sumarry:** Build Number 139 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=1 Skipped=4

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

2016-02-22 Thread miguelaferreira
Github user miguelaferreira closed the pull request at: https://github.com/apache/cloudstack/pull/1285 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

2016-01-04 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1285#issuecomment-168905195 @remibergsma In the FS there is a requirement "Cloud admin should be able to to map AD OU / group to a Domain in CloudStack". So this means that LDAP group is

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

2015-12-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1285#issuecomment-167585886 LGTM, works as expected. ![screen shot 2015-12-28 at 16 08

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

2015-12-28 Thread borisroman
Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1285#discussion_r48488856 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java --- @@ -111,19 +114,27 @@ public

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

2015-12-28 Thread miguelaferreira
Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1285#discussion_r48496732 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java --- @@ -111,19 +114,27 @@ public

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

2015-12-28 Thread borisroman
Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1285#discussion_r48498393 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java --- @@ -111,19 +114,27 @@ public

[GitHub] cloudstack pull request: Map ldap group to Cloudstack account

2015-12-23 Thread miguelaferreira
Github user miguelaferreira closed the pull request at: https://github.com/apache/cloudstack/pull/1284 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

2015-12-23 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1285#issuecomment-166936459 I've tested this PR manually in our beta environment, however ince there is a marvin test for this functionality I would also like to run that. I haven't

[GitHub] cloudstack pull request: Map ldap group to Cloudstack account

2015-12-23 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1284#issuecomment-166936174 I've tested this PR manually in our beta environment, however ince there is a marvin test for this functionality I would also like to run that. I haven't

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

2015-12-23 Thread miguelaferreira
GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/1285 Map LDAP group to Cloudstack account The LDAP plugin authenticates Cloudstack users against users in an LDAP group, and when doing so creates a Cloudstack account with the same name as

[GitHub] cloudstack pull request: Map ldap group to Cloudstack account

2015-12-23 Thread miguelaferreira
GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/1284 Map ldap group to Cloudstack account The LDAP plugin authenticates Cloudstack users against users in an LDAP group, and when doing so creates a Cloudstack account with the same name as

[GitHub] cloudstack pull request: Map ldap group to Cloudstack account

2015-12-23 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1284#issuecomment-166936278 Closing as this should have been directed at 4.7 branch. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

2015-12-23 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1285#issuecomment-167044637 @miguelaferreira Looks like this PR is going to impact the feature https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP%3A+Trust+AD+and+Auto+Import that