Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/23#issuecomment-59356773
Hi Daan, I can help merging things on daily basis but not sure about
official RM position :)
I'm going ahead with the merge. I was just waiting for Travis to
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/23#issuecomment-59348377
Seems like you are the RM for 4.6/master now Rohit, congratulations. I
suggest that you and @ke4qqq do a merge like this on a daily basis. Of course I
would like
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/23#issuecomment-59347522
Mostly LGTM.
I found a pattern that all the baremetal changes are causing issues, from
the JIRA issue [1] this feature is in progress and I would only request
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/23#discussion_r18949772
--- Diff:
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java
---
@@ -238,7 +232,7 @@ private boolean
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/23#discussion_r18949755
--- Diff: api/src/com/cloud/event/EventTypes.java ---
@@ -454,7 +454,6 @@
public static final String EVENT_BAREMETAL_PXE_SERVER_ADD =
"PHYSICAL.P
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/23
Merge 4.5 back into master
It would be good to have this as a daily practice
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland
