[GitHub] cloudstack pull request: Merge 4.5 to master

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/53#issuecomment-66985696 I will need to look into it. If we don't want to do a force push, then maybe we can wait to do this new -2 branch…because we would need to do it again and

[GitHub] cloudstack pull request: Merge 4.5 to master

GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/53 Merge 4.5 to master You can merge this pull request into a Git repository by running: $ git pull https://github.com/karuturi/cloudstack merge-45-to-master-2 Alternatively you can review

[GitHub] cloudstack pull request: Merge 4.5 to master

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/53#issuecomment-66041167 Thanks Rajani for the PR, let's merge as soon as Travis passes. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Merge 4.5 to master

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/53#issuecomment-66043331 sure Rohit.. waiting for travis to finish. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Merge 4.5 to master

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/53#issuecomment-66044338 Hi folks, any chance to try those merges with the noawsapi branch ? I am working on IP clearance for ec2stack and gstack and once we get that under the project, I

[GitHub] cloudstack pull request: Merge 4.5 to master

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Merge 4.5 to master

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/53#issuecomment-66103841 sure @runseb. I can help with that. rebase master on noawsapi branch would required a force push. This is what I think we can do here is 1. create a new

Re: [GitHub] cloudstack pull request: Merge 4.5 to master

Thanks for keeping at it Rajani, I gave up yesterday on merging the 4.4.2 to 4.5.0 upgrade code after it resulted in a merge mess. These changes are not in your pull request (yet?). Also I see travis failures mentioned. So I think we are not ready for this. The upgrade code contained quite some

[GitHub] cloudstack pull request: Merge 4.5 to master

Github user karuturi closed the pull request at: https://github.com/apache/cloudstack/pull/45 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [GitHub] cloudstack pull request: Merge 4.5 to master

Hi Daan, It had your upgrade changes(a52fd08a142edc6a62e43838113bc504c225fa11). It gave me some merge conflicts and resolved them in favour of master as the changes are already there on master. Checking the travis build history shows that there are failures in the past builds as well. It may not

[GitHub] cloudstack pull request: Merge 4.5 to master

GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/45 Merge 4.5 to master You can merge this pull request into a Git repository by running: $ git pull https://github.com/karuturi/cloudstack merge45-to-master Alternatively you can review and

[GitHub] cloudstack pull request: Merge 4.5 to master

Github user karuturi closed the pull request at: https://github.com/apache/cloudstack/pull/42 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Merge 4.5 to master

GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/42 Merge 4.5 to master You can merge this pull request into a Git repository by running: $ git pull https://github.com/karuturi/cloudstack merge-45-to-master Alternatively you can review

[GitHub] cloudstack pull request: Merge 4.5 to master

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Merge 4.5 to master

GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/38 Merge 4.5 to master I saw conflicts in the following two commits and resolved in favour of master commit 4.5: d82e556dcd980bac50f27eaca284983808e04b1c master:

[GitHub] cloudstack pull request: Merge 4.5 to master

Github user karuturi closed the pull request at: https://github.com/apache/cloudstack/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Merge 4.5 to master

GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/36 Merge 4.5 to master You can merge this pull request into a Git repository by running: $ git pull https://github.com/karuturi/cloudstack merge-4.5-to-master Alternatively you can review