[GitHub] cloudstack pull request: Refactor/citrix resource base rebase

2015-04-02 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/137#issuecomment-89023853 Thanks a lot, man! Will keep an eye on Master. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Refactor/citrix resource base rebase

2015-04-02 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/137#issuecomment-88999899 Skimmed over diff, looks good. Built after merging branch and was able to deploy a basic zone and do basic vm lifecycle tests. TravisCI is green as well, so merging.

[GitHub] cloudstack pull request: Refactor/citrix resource base rebase

2015-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Refactor/citrix resource base rebase

2015-04-01 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/137#issuecomment-88510623 Addced documentation here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Refactoring+CitirxResourceBase+class --- If your project is set up for it,

[GitHub] cloudstack pull request: Refactor/citrix resource base rebase

2015-03-31 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/137#issuecomment-88354995 Hi @wilderrodrigues, I'll try to review and test it soon. Thanks for the PR. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] cloudstack pull request: Refactor/citrix resource base rebase

2015-03-31 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/137 Refactor/citrix resource base rebase Hi Rohit (@bhaisaab) It's a huge piece of work, but it has been extensively tested. Could you please have a look? :) Thanks in adva