Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/855
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-175669973
Merging based on comments and 2LGTMs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-162533617
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_v
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-162284601
LGTM. I am ok with this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-162243277
@anshul1886 I trust you are alright with this change in comment, are you?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-162006901
@DaanHoogland, I just used the link there because before the link that was
presented by @anshul1886, we have not being able to find that page.
I ag
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-161981047
Based on code review I can live with this, though I am not happy with
wiki-links in javadoc. wiki links may change independant of versions of the
code.
---
If
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-161957476
@anshul1886, we really tried to look up some doc about the use of that
class, unfortunately nothing came up on our google searches. After reading the
link
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-161926840
This file could be used while fixing some time taking bugs in Console Proxy
code. It can be used in similar way as described on
https://cwiki.apache.org/confluenc
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-161918331
@rafaelweingartner @alexandrelimassantana Did you test whether the console
proxy is still in there?
@anshul1886 Do you or any of your colleagues have the opo
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-161389994
@bhaisaab, we definitely should test that. Since there were none references
of that class, we suggested removing it. ACS uses spring, and since there is
ne
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-161352903
LGTM (only code review), but we need to test it and verify console proxy
functionality
---
If your project is set up for it, you can reply to this email and have y
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-158746107
@alexandrelimassantana, Could you squash your commits ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-141721624
Hi @alexandrelimassantana,
I checked and also could not find any references for that class. That is
nice that you are removing some code that was left
GitHub user alexandrelimassantana opened a pull request:
https://github.com/apache/cloudstack/pull/855
Removal of class AgentBasedStandaloneConsoleProxyManager
The AgentBasedStandaloneConsoleProxyManager class is neither manually
instatiated anywhere in the code nor via Spring. F
15 matches
Mail list logo
