Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-151547183
@remibergsma I see. Next time I will try to rebase it with master before
commiting.
---
If your project is set up for it, you can reply to this email and have y
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-151489875
@rodrigo93 it helps when running the tests. But never mind, I will rebase
myself and then run the tests :-)
---
If your project is set up for it, you can reply
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-151206169
Hi @remibergsma, the files that I am changing were not altered in the
current master. Why do we need to rebase?
Thanks for your time.
---
If your project is s
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-150835745
Thanks @rodrigo93, please also rebase with current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-150824034
Hi @remibergsma, thanks for the advice!
I have changed the title of the last commit already as you both suggest.
I will provide a JIRA issue and prepend th
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-150672917
@rodrigo93 Thanks for squashing! Could you also rename the commit title to
something more sensible?
---
If your project is set up for it, you can reply to this e
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-149059531
@rafaelweingartner Thanks for the advice! I am squashing them right now. I
will commit again as soon as possible.
---
If your project is set up for it, you can re
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-149024165
@rodrigo93, nice work. However, you forgot an entry in
/cloud-client-ui/pom.xml.
If that âcloud-plugin-storage-allocator-randomâ is not needed you
GitHub user rodrigo93 opened a pull request:
https://github.com/apache/cloudstack/pull/943
Removed unused adapters from async-job-component.xml.
I was looking the file /cloud-server/test/async-job-component.xml, and I
found an adapter configuration that seems to have no use. The rea
