Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/942#issuecomment-161352291
LGTM (only code review)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/942#issuecomment-161433986
@DaanHoogland That expunge issue is now resolved in the integration tests,
my bad :-s
---
If your project is set up for it, you can reply to this email and
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/942
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/942#issuecomment-161077181
I had to run one test a couple of times it is bugging us lately:
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/942#issuecomment-158935886
I've pushed another commit to bring this PR up to date with the latest
snapshot but it seems the Travis build had some issues sorting out some
dependencies.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/942#issuecomment-158940788
@cristofolini you can force push, more important is that the regression
suites are run on it. ping @remibergsma ?
---
If your project is set up for it, you
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/942#issuecomment-151547785
Based on the fact that all the code builds and the UnitTests are also
running properly I can give this one a LGTM
---
If your project is set up for it, you can reply
GitHub user cristofolini opened a pull request:
https://github.com/apache/cloudstack/pull/942
Removed unused code from the EngineHostDao Implementation
After analysing the code within the EngineHostDaoImpl class, we noticed
that methods:
countBy;
findByGuid;
