[GitHub] cloudstack pull request: Removed unused methods from XenServerConnectionPool

2016-05-31 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1557 No I am talking about the problems with TrustAllManager. I am not convinced there is a problem by the not by @rodrigo93 . --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Removed unused methods from XenServerConnectionPool

2016-05-31 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1557 @DaanHoogland are you asking about the code at lines 53-70? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: Removed unused methods from XenServerConnectionPool

2016-05-31 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1557 @rodrigo93 @rafaelweingartner Do you have a scenario that proves these methods to be a problem? returning true or null (or void) does not imply a problem unless the result can be abu