[GitHub] cloudstack pull request: Removed unused parameters and variable fr...

2016-03-21 Thread pedro-martins
Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/1447#issuecomment-199337285 Hi @DaanHoogland. I did a maven install (this executes the unit tests). Also, the PR has passed in the Jenkins and the CI tests. However, I did not

[GitHub] cloudstack pull request: Removed unused parameters and variable fr...

2016-03-21 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1447#issuecomment-199207256 @pedro-martins How did you validate you didn't break anything? Was this work based on code analysis alone? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Removed unused parameters and variable fr...

2016-03-19 Thread pedro-martins
GitHub user pedro-martins opened a pull request: https://github.com/apache/cloudstack/pull/1447 Removed unused parameters and variable from NetworkHelper hierarchy - Was removed the unused params User & Account in the