[GitHub] cloudstack pull request: Squashing two commits in to single commit

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1411#issuecomment-184636485 @runseb very sorry but I saw @remibergsma LGTM above here in this PR. please revert. I have not looked into this PR. --- If your project is set up for it, you

[GitHub] cloudstack pull request: Squashing two commits in to single commit

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/1411#issuecomment-184633589 @DaanHoogland @sanjeevneelarapu you guys are writing the code so I have nothing to say...but @remibergsma asked for updating the PR message and nothing was done. Now

[GitHub] cloudstack pull request: Squashing two commits in to single commit

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1411 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [GitHub] cloudstack pull request: Squashing two commits in to single commit

LGTM based on PR#667 On Mon, Feb 15, 2016 at 5:37 PM, DaanHoogland wrote: > Github user DaanHoogland commented on the pull request: > > https://github.com/apache/cloudstack/pull/1411#issuecomment-184182132 > > @sanjeevneelarapu If you LGTM this there are 2 LGTM here so please go > ahead

[GitHub] cloudstack pull request: Squashing two commits in to single commit

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1411#issuecomment-184182132 @sanjeevneelarapu If you LGTM this there are 2 LGTM here so please go ahead and merge. --- If your project is set up for it, you can reply to this email and h

Re: [GitHub] cloudstack pull request: Squashing two commits in to single commit

Is it okay to merge this PR or we need to wait for two LGTMs, since original PR 667 already has two LGTMs ? On Fri, Feb 12, 2016 at 1:59 PM, remibergsma wrote: > Github user remibergsma commented on the pull request: > > https://github.com/apache/cloudstack/pull/1411#issuecomment-183226537 >

[GitHub] cloudstack pull request: Squashing two commits in to single commit

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1411#issuecomment-183226537 Thanks! LGTM, based on #667. I'd suggest though to make the commit message and PR title more descriptive. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Squashing two commits in to single commit

GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/1411 Squashing two commits in to single commit CLOUDSTACK-8717: Failed to start instance after restoring the running instance -Modified code to add tag to aonly one cluster wide SP