Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/17#issuecomment-54790328
Leo, you are right but if it is in 4.3 not putting it in 4.4 would make it
a double behavioural change from a user perspective. So I will look at
cherry-pic
Github user lsimons commented on the pull request:
https://github.com/apache/cloudstack/pull/17#issuecomment-54785217
Hey Daan, _this_ change is fine&done as-is. Like Rajani mentioned, the
other changes to that file could be ported, too. I'm +0 on that -- on the one
hand, it's a good
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/17#issuecomment-54777280
4.4:packaging/debian/init/cloud-usage already has the new logic to set
$JAVA_HOME (e77da80e01b0774951e5c2ab1b23539af002b8b4)
Given that it is already in 4.3(
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/17#issuecomment-54707381
I merged it without closely reading the comment in #15. Does other logic
need to ported as well, Leo?
---
If your project is set up for it, you can reply to this
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
GitHub user lsimons opened a pull request:
https://github.com/apache/cloudstack/pull/17
bugfix/CLOUDSTACK-7476 for 4.4 branch.
See https://github.com/apache/cloudstack/pull/15 for the pull request
that was merged to master & associated discussion.
You can merge this pull reques
