Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-175504959
Such a waste
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1279
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-174326800
Ok let me rephrase as well: this is extra code without extra functionality:
:-1:
---
If your project is set up for it, you can reply to this email and have y
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-174211604
@bhaisaab Let me rephrase: I tested your PR and that works :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-174211155
I've heard everyone's comments on this, I stand by my PR. The argument that
DB upgrade works is not relevant to what this PR fixes.
---
If your project is set up
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-174196682
For the record: the upgrade works:
```
2016-01-23 16:06:44,796 INFO [c.c.u.DatabaseUpgradeChecker] (main:null)
(logid:) DB version = 4.6.2 Code Ver
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-172369667
I don't see the semantic necessity for this. doe upgrades work different if
Upgrade461to470() is used insted of an empty Upgrade462to470()? It is just
adding
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-169133536
Didn't have a chance to test it yet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-169133233
Did the tests succeed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-168902444
Ping @remibergsma
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-166883594
@bhaisaab Thanks, makes sense. Will test an upgrade and report back.
---
If your project is set up for it, you can reply to this email and have your
reply appea
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1279
engine/schema: Use semantically correct upgrade path 4.6.2->4.7.0
Adds an explicit upgrade path class from 4.6.2 to 4.7.0, that extends over
the upgrade path from 4.6.1 to 4.7.0
cc
12 matches
Mail list logo
