Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/538#issuecomment-118848745
LGTM.
Please proceed with merge
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/538
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/538#issuecomment-117444046
Hi @DaanHoogland
@K0zka als added a unit tests to cover his changes. Check this class:
CreateSecondaryStagingStoreCmdTest
Any chance to
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/538#issuecomment-117022539
Changes looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/538
findbugs: impossible cast(s) fixed by changing field types
By model of Laszlo's earlier changes, this one was bothering me as the
model was a litle more complex at first sight. Turns out
