[GitHub] cloudstack pull request: findbugs: repeated condition seems c&p er...

2015-06-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: findbugs: repeated condition seems c&p er...

2015-06-19 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/491#issuecomment-113498905 @DaanHoogland looks like you're right, we should be trying to delete a volume that is already destroyed, expunged or is being expunged. LGTM, merging now. --- If

[GitHub] cloudstack pull request: findbugs: repeated condition seems c&p er...

2015-06-19 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/491 findbugs: repeated condition seems c&p error the tested states sugest that EXPUNGED should be the last one. Might be that it can be removed altogether instead. @mike-tutkowski @bhaisa