Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-213438660
Thanks for all the effort @bhaisaab. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1397
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-213397292
@swill closing this PR, opened two new PRs that split changes from this PR
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-212063724
@swill no problem, I'll deal with this during weekends and see how much we
can safely get into master.
---
If your project is set up for it, you can reply to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-211932110
@bhaisaab thank you sir. sorry this is proving to be a bit complicated. i
appreciate the support.
---
If your project is set up for it, you can reply to this
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-211786322
@swill thanks Will, I'll try to split this PR into two to isolate what
changes are causing this in your env and see if we can get it fixed/improved
separately
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-211725428
@bhaisaab I am still getting compile errors. I will reconfigure my CI
environment to use an older version of Java to see if that fixes the problem.
```
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-211263699
@swill advise how to proceed on this one? are you still getting the build
issues
@DaanHoogland ping
---
If your project is set up for it, you can reply to
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-205867477
@DaanHoogland feel free to split this however you feel, I've already moved
the Travis fix to a separate PR
---
If your project is set up for it, you can reply to
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-205755506
@bhaisaab I'm kind of confused, you write about three parts but I count
four. I would agree that the bouncy castle is a completely seperate one. I
think mvn
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-205154145
@DaanHoogland do you want to have a look, if you can help fix the issue of
building against latest openjdk and advise if bountycastle related changes are
causing
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-205149639
@swill I share what worked for me, I'm not saying you have to use
oracle-java. The openjdk version 1.7.0_85+ causes test failures for building
console proxy in my
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-204714215
@bhaisaab: whether or not we 'can' find a working configuration is not
really the point here. I don't think it is acceptable that we break support for
`openjdk` and
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-204648798
@swill can you try again with oracle java 1.7.0_80 there are known
certificate and cipher suite issues causing build issues when using
1.7.0_90+. JDK8 is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-204527828
I get the same behavior with Java 7.
```
$ mvn --version
Apache Maven 3.0.5 (Red Hat 3.0.5-16)
Maven home: /usr/share/maven
Java version:
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-204520010
I have changed the way my CI environment is being built, so it is built to
use Java 7 now. I am testing this PR now, so I will update with status when I
have
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-204494886
@swill Java8 is not currently supported by the management server. We know
that the process will collapse after running for 24-48 hours. Part of the
issue is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-204490175
There were quite a few changes to the way certificates are handled in this
PR. Changes to versions of bouncycastle as well as changing the way the Pem
files are
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-204486265
What about this PR forces me to downgrade to Java 7? My Java 8 build
environment has been working fine against master until this PR.
---
If your project is set
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-204474193
@swill based on the output you've shared from your CI env -- `Java version:
1.8.0_77, vendor: Oracle Corporation`; you're using Java 8. Please switch to
Java 7
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-204470246
The above results are from my CI environment which is running the following:
```
$ mvn --version
Apache Maven 3.0.5 (Red Hat 3.0.5-16)
Maven home:
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-204472158
Here is the core dump I had originally when I tried to build on my mac.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-204429261
@swill I'm guessing an environment issue, likely an empty java keystore;
what is the version of your maven, java? Are you using Oracle Java or OpenJDK?
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-204396178
This is failing to build in my CI environment. The following tests are
causing the build to fail.
It is failing here:
```
[INFO] Apache CloudStack
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-202369219
+1 to all the Travis changes based on code review and verification of
travis tests. I would have put those changes in a separate PR however.
---
If your project is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-201892908
@bvbharat np, looking forward to improvements
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-201730345
@bhaisaab
apologies for the late reply, I was busy working on some of the internal
work and did not notice you comment. I am aware of some of these
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-201657556
@swill I've fixed for Travis now, locally I was successfully able to run
more than 50 smoke/component tests against simulator. The Travis test result
printer is
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-201497762
@swill I agree there a lot of incongruent changes in this PR. I would like
to see it decomposed. For example, the Bouncy Castle upgrade should be
completely
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-201496521
@swill Travis has been failing for several PRs when the test exceed the
timeout period (30mins) https://travis-ci.org/apache/cloudstack/jobs/117688064
This has
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-201491672
There is a lot going on here and I don't like that Travis is failing since
it tends to be pretty stable. Also, Travis is failing with a "Pull Request
#1397 maven:
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1397#discussion_r56989840
--- Diff: pom.xml ---
@@ -65,58 +61,68 @@
0.5
3.0
-4.11
+4.12
1.3
-1.46
-0.1.51
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1397#discussion_r56989049
--- Diff: pom.xml ---
@@ -65,58 +61,68 @@
0.5
3.0
-4.11
+4.12
1.3
-1.46
-0.1.51
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1397#discussion_r56987982
--- Diff: pom.xml ---
@@ -65,58 +61,68 @@
0.5
3.0
-4.11
+4.12
1.3
-1.46
-0.1.51
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1397#discussion_r56978327
--- Diff: pom.xml ---
@@ -65,58 +61,68 @@
0.5
3.0
-4.11
+4.12
1.3
-1.46
-0.1.51
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-199781638
@bhaisaab I see you upgraded gson. Last time i tried that the integration
tests started failing massively. I wasted a couple of day back then. did you
verify
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-199775804
@swill rebased against latest master /cc @DaanHoogland
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-196757927
@bvbharat Thanks for sharing, some failures could be due to env related
issue. Please see if my comments below help you to improve your infra:
- Tests
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-196753522
### ACS CI BVT Run
**Sumarry:**
Build Number 97
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=9
Skipped=4
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-196205318
@bvbharat nice work, saw you ran BVT tests on #1415 (which was closed and
merged here). Can you run and share results for this PR? Thanks.
---
If your project is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-179751806
@wido not all updates are backwards compatible, I included the simpler
changes for some.
---
If your project is set up for it, you can reply to this email
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-179742046
You also change Java code at the same time. Shouldn't this PR ONLY upgrade
maven. Nothing more?
---
If your project is set up for it, you can reply to this email and
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-179847902
Ok, @DaanHoogland I understand.
Tests seem to fail though. Is that legit?
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-179850018
The travis tests, huh? haven't looked at those in a long time as these were
failing always. Jenkins builds and the real test needed is integration tests.
---
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1397
maven: Upgrade dependency versions
Updated most dependencies to latest minor releases, except:
- Gson 2.x
- Major spring framework version
- Servlet version
- Embedded
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-178750977
Reopened from https://github.com/apache/cloudstack/pull/1393 with the
branch on ASF remote. cc @DaanHoogland
---
If your project is set up for it, you can reply
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1393#issuecomment-178750332
@DaanHoogland how about this, I close this PR; push the branch to asf
remote and you continue on that branch keeping the same PR?
---
If your project is set up
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1393
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-178759820
@DaanHoogland I've tested this and fix an issue, please feel free to make
changes directly on this branch
---
If your project is set up for it, you can reply to
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1393
maven: Upgrade dependency versions and to maven 3.3.9
Skipped: (but upgraded to latest minor release)
- Major spring framework version
- Servlet version
- Embedded jetty version
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1393#issuecomment-178705720
@bhaisaab could you move the version numbers to the root pom instead of
updating the project poms?
---
If your project is set up for it, you can reply to
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1393#issuecomment-178706313
@DaanHoogland sure will do this weekend, this was mostly edited by the
maven versions plugin. Do you want to work on this, as you may have some
version related
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1393#issuecomment-178710383
I will integrate them, and make a PR to this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
53 matches
Mail list logo
