[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-06-21 Thread shwetaag
Github user shwetaag closed the pull request at: https://github.com/apache/cloudstack/pull/153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-06-21 Thread shwetaag
Github user shwetaag commented on the pull request: https://github.com/apache/cloudstack/pull/153#issuecomment-114021543 @gauravaradhye and @DaanHoogland another request for this was created https://github.com/apache/cloudstack/pull/184 and @sanjeevneelarapu reviewed it

[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-06-19 Thread gauravaradhye
Github user gauravaradhye commented on the pull request: https://github.com/apache/cloudstack/pull/153#issuecomment-113532279 @DaanHoogland Let's wait for @shwetaag to respond. The patch is not yet updated after the review comments. --- If your project is set up for it, you can repl

[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-06-19 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/153#issuecomment-113523348 @shwetaag are you still working on this? (if not can you close it?) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-06-19 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/153#issuecomment-113523123 @gauravaradhye is it to be merged, is extra work necessary? --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-06-02 Thread gauravaradhye
Github user gauravaradhye commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/153#discussion_r31501168 --- Diff: test/integration/component/test_escalations_templates.py --- @@ -915,3 +968,223 @@ def test_04_copy_template(self): )

[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-06-02 Thread gauravaradhye
Github user gauravaradhye commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/153#discussion_r31500922 --- Diff: test/integration/component/test_escalations_templates.py --- @@ -55,23 +63,68 @@ def setUpClass(cls): cls.hypervisor = cls

[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-06-02 Thread gauravaradhye
Github user gauravaradhye commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/153#discussion_r31501000 --- Diff: test/integration/component/test_escalations_templates.py --- @@ -915,3 +968,223 @@ def test_04_copy_template(self): )

[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-06-02 Thread gauravaradhye
Github user gauravaradhye commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/153#discussion_r31500783 --- Diff: test/integration/component/test_escalations_templates.py --- @@ -915,3 +968,223 @@ def test_04_copy_template(self): )

[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-06-02 Thread gauravaradhye
Github user gauravaradhye commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/153#discussion_r31500745 --- Diff: test/integration/component/test_escalations_templates.py --- @@ -915,3 +968,223 @@ def test_04_copy_template(self): )

[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-06-02 Thread gauravaradhye
Github user gauravaradhye commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/153#discussion_r31500546 --- Diff: tools/marvin/marvin/config/test_data.py --- @@ -791,6 +791,8 @@ "displaytext": "xs", "name": "xs", "

[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-06-02 Thread gauravaradhye
Github user gauravaradhye commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/153#discussion_r31500491 --- Diff: test/integration/component/test_escalations_templates.py --- @@ -55,23 +63,68 @@ def setUpClass(cls): cls.hypervisor = cls

[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-06-02 Thread gauravaradhye
Github user gauravaradhye commented on the pull request: https://github.com/apache/cloudstack/pull/153#issuecomment-107853053 @terbolous yes I will review this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-05-28 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/153#issuecomment-106607317 @gauravaradhye is this something you could take a look at? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-04-09 Thread shwetaag
GitHub user shwetaag opened a pull request: https://github.com/apache/cloudstack/pull/153 verifying template creation permission based on global parameter Test to create Public Template by registering or by snapshot and volume when Global parameter 'allow.public.user.temp