rafaelweingartner closed pull request #16: Change systemvm template from 4.6 to
4.11
URL: https://github.com/apache/cloudstack-documentation/pull/16
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance
wido commented on issue #16: Change systemvm template from 4.6 to 4.11
URL:
https://github.com/apache/cloudstack-documentation/pull/16#issuecomment-435129113
LGTM
This is an automated message from the Apache Git Service
GabrielBrascher opened a new pull request #16: Change systemvm template from
4.6 to 4.11
URL: https://github.com/apache/cloudstack-documentation/pull/16
Fix System VM template download path from 4.6 to 4.11.1
.com> wrote:
> >
> > Following the protocol defined in [1], this is the notice email
> regarding the removal of "4.6.*-RC*" branches from Apache CloudStack
> official repository. The Jira ticket for the branches removal is
> https://issues.apache.org/j
il regarding
the removal of "4.6.*-RC*" branches from Apache CloudStack official
repository. The Jira ticket for the branches removal is
https://issues.apache.org/jira/browse/CLOUDSTACK-10313. The branches that
will be removed are the following:
>
> 4.6.0-RC20151104T1522
> 4.6.0-RC201511
Following the protocol defined in [1], this is the notice email regarding
the removal of "4.6.*-RC*" branches from Apache CloudStack official
repository. The Jira ticket for the branches removal is
https://issues.apache.org/jira/browse/CLOUDSTACK-10313. The branches that
will
Marc,
Does changing the path from .ova to .vmdk help at all? Also, is it a data
volume or a ROOT volume?
Thanks,
-Syed
On Thu, May 4, 2017 at 6:44 AM, Marc Poll Garcia <marc.poll.gar...@upcnet.es
> wrote:
> Hi all,
>
> i'm not able to download a "volume" on clo
Hi all,
i'm not able to download a "volume" on cloudstack 4.6, having a 403
forbidden instead.
I've just upgraded our cloudstack version to 4.6, so i'm performing a list
of tests to confirm the usage is ok.
My setup is the following one:
- 1 x cloudstack managment server
- 1 x b
Hi!
We're recently hit by some gateway problems. In an 4.9 advanced zone,
shared network, a virtualrouter vm does dns and dhcp.
This router vm sometimes offers itself as default gateway.
I tried to trace this down, but I can't find the real problem.
Anyway, in /etc/dnsmasq.conf all entries are
16 10:28, "Octavian Popescu"
<octavian.pope...@interoute.com<mailto:octavian.pope...@interoute.com><mailto:octavian.pope...@interoute.com>>
wrote:
Hello,
There seems to be a bug in CS 4.6 that prevents a VM running on VMWare from
booting if it has more than 7 NICs – the NICs c
t;On 06/05/2016 10:28, "Octavian Popescu"
><octavian.pope...@interoute.com<mailto:octavian.pope...@interoute.com>> wrote:
>
>Hello,
>
>There seems to be a bug in CS 4.6 that prevents a VM running on VMWare from
>booting if it has more than 7 NICs – the NICs can b
interoute.com<mailto:octavian.pope...@interoute.com>> wrote:
Hello,
There seems to be a bug in CS 4.6 that prevents a VM running on VMWare from
booting if it has more than 7 NICs – the NICs can be added just fine until you
hit the VMWare limit (10) but on reboot it doesn’t start anymore
Mike Tutkowski wrote:
> > Interesting – yeah, this VR seems to be stuck in the Starting state.
> >
> > Not sure what to do about it.
> >
> > As you noted, 4.6 and later behave like this. I can observe the VR
> entering
> > the Starting state properly on 4.5.
> >
>
t;
> As you noted, 4.6 and later behave like this. I can observe the VR entering
> the Starting state properly on 4.5.
>
> On Monday, February 8, 2016, Paul Angus <paul.an...@shapeblue.com> wrote:
>
>> Hi Mike,
>>
>> I have the VR running in a 4.8 VMware advance
Interesting – yeah, this VR seems to be stuck in the Starting state.
Not sure what to do about it.
As you noted, 4.6 and later behave like this. I can observe the VR entering
the Starting state properly on 4.5.
On Monday, February 8, 2016, Paul Angus <paul.an...@shapeblue.com> wrote:
>
Hi Mike,
I have the VR running in a 4.8 VMware advanced zone.
I have noticed a new behaviour since 4.6 - that VMware system VMs don't report
'Running' until they've successfully called home.
[ShapeBlue]<http://www.shapeblue.com>
Paul Angus
VP Technology , ShapeBlue
d: +
>>>
>>>> > Note: The CS MS is saying it can't connect to the virtual router. I
>>>> can
>>>> > ping the virtual router manually from the CS MS, but I can't SSH into
>>>> it
>>>> > (not sure if I should be
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1265#issuecomment-166304851
LGTM,
Looking at that database upgrade checker that does not just check but also
upgrade the ACS schema, I got me thinking that there has to be a
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1265#issuecomment-166311506
And it works:
```
INFO [o.a.c.s.l.CloudStackExtendedLifeCycle] (main:null) Running system
integrity checker
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1265
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1265#issuecomment-166305178
@rafaelweingartner True story, the faster we release versions the harder it
becomes. It needs to be changed, preferably in a tool outside of CloudStack. We
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1265#issuecomment-166305826
I understand you; I will have a look at that, to see how other projects
deal with that kind of problem. If I find something interesting I will bring
that
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1265#issuecomment-166304038
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1265
Set version 4.6.3-SNAPSHOT in 4.6 branch
- setnextversion.sh
- upgrade path
Build succeeds:
```
[INFO
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1182#issuecomment-162850730
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
Hi all,
We managed to get quite some PRs merged in over the last few days. Thanks for
helping out! It will be a great new release with interesting new features and
of course some bugs fixed.
One PR that didn’t make it, is the VPN improvement and that’s a pity. It seems
Jayapal was working on
Hi,
I am having a problem getting the virtual router to leave the "Starting"
state on 4.6 and 4.7.
I am making use of the correct system VM template in each case, but the
virtual router claims it requires an upgrade.
This is in a Basic Zone and using local storage for the system VMs.
gt; I am having a problem getting the virtual router to leave the "Starting"
> state on 4.6 and 4.7.
>
> I am making use of the correct system VM template in each case, but the
> virtual router claims it requires an upgrade.
>
> This is in a Basic Zone and using local storage f
(not sure if I should be able to).
>
> On Mon, Dec 7, 2015 at 3:14 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com
> > wrote:
>
> > Hi,
> >
> > I am having a problem getting the virtual router to leave the "Starting"
> > state on 4.6 and 4.7.
> (not sure if I should be able to).
> >
> > On Mon, Dec 7, 2015 at 3:14 PM, Mike Tutkowski <
> > mike.tutkow...@solidfire.com
> > > wrote:
> >
> > > Hi,
> > >
> > > I am having a problem getting the virtual router to l
r. I can
>> > ping the virtual router manually from the CS MS, but I can't SSH into it
>> > (not sure if I should be able to).
>> >
>> > On Mon, Dec 7, 2015 at 3:14 PM, Mike Tutkowski <
>> > mike.tutkow...@solidfire.com
>> > > wrote
rtual router manually from the CS MS, but I can't SSH into
>>> it
>>> > (not sure if I should be able to).
>>> >
>>> > On Mon, Dec 7, 2015 at 3:14 PM, Mike Tutkowski <
>>> > mike.tutkow...@solidfire.com
>>> > > wrot
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1175#issuecomment-162286626
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1175
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1175#issuecomment-162340165
lgtm merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1171
[4.6/master] rate-limit: increase JVM memory and enable fork mode for unit
tests
Enables forkmode for surefire plugin and increases memory opts for JVM
for rate-limit tests. This tries
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1171#issuecomment-161920716
@bhaisaab How can I help testing this? Also, your branch mentions 4.6 but
the PR is made against master branch. Is that correct? Just checking ;-)
---
If your
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1171#issuecomment-161921440
@remibergsma thanks, not sure why this happened again. This was supposed to
be for 4.6, will recreate a new PR. I'm not sure on how to test it, it's just
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1175
[4.6/master] rate-limit: increase JVM memory and enable fork mode for unit
tests
Enables forkmode for surefire plugin and increases memory opts for JVM
for rate-limit tests. This tries
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Here's the 4.6 based PR https://github.com/apache/cloudstack/pull/1175
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161885184
@bhaisaab Check! This I cannot merge to 4.6 with this PR so if you make one
against 4.6 that would be easy. Mention this one so it can go through faster
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161878014
@remibergsma let me know if you want me to open a new PR against 4.6 branch.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161877977
@remibergsma sorry for the source/target branches; this needs to go into
both 4.6 and master branches. So merge on 4.6, and fwd-merge 4.6 on master.
Thanks
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161898597
@remibergsma thanks, opened another PR #1169 please merge that. Closing
this one, as once the other PR will be merged on 4.6 and 4.6 on master; we
won't need
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1155#issuecomment-161569317
Will run some tests to double check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1151#issuecomment-161557568
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1155
Merge 4.6
there is one (simple) conflict so for formailty's sake I make this a pull
request.
@utscweizhou en @remibergsma please have a look/test-run
You can merge this pull request
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1151#issuecomment-161549425
@remibergsma @borisroman
Please, be aware that there is a change in the
```tools/marvin/marvin/lib/common.py``` file. It means that you have to
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1155#issuecomment-161568869
LGTM,
code are almost same to #1029 , fine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1151#issuecomment-161557066
The test passes fine here, also on a 2 node cluster:
test_01_vpc_privategw_acl
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... ===
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1151#issuecomment-161595328
@remibergsma time to merge! It also got a LGTM from @DaanHoogland :)
Cheers,
Wilder
---
If your project is set up for it, you can reply to
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161709051
Seems good, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1151
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1155#issuecomment-161745983
LGTM, run some tests and they are all fine:
```
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1155
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161748134
@bhaisaab Should I merge this to master, or should it be merged to 4.6?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1151#issuecomment-161428530
@wilderrodrigues Will start some tests!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161429236
Makes sense, LGTM also based on the successful job above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161216838
Test jenkins build job:
http://sb.bhaisaab.org:/job/deb-shapeblue-build-patch-noredist/103/console
---
If your project is set up for it, you can reply to
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1151#issuecomment-161434770
Ping @DaanHoogland @remibergsma @borisroman @bhaisaab
More tests!
* Tests executed
```
nosetests --with-marvin
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161437830
Ping @borisroman to have a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1151#issuecomment-161484253
given the number of tests done I am fine with this. I also reviewed the
code, lgtm, I am not confident to put it in capitals but am floating on my
experience
!
* Environment:
* ACS 4.6 branch
* Hardware required: TRUE
* Management Server + MySQL on CentOS 7.1
* One KVM Host on CentOS 7.1
* Agent + Common RPMs built from source
* Tests executed
```
nosetests --with-marvin
--marvin-config=/data/shared/marvin
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/1151
[4.6] CLOUDSTACK-9075 - As a Developer I want the Private GW feature fixed
on single VPCs
This PR fixes the issue we faced with Private Gateways on single VPC when
using ACS 4.6.0
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1151#issuecomment-161274671
Ping @remibergsma @DaanHoogland @borisroman
You can start testing now... just a matter of running the following:
```
cd
will now run more tests.
* Environment:
* ACS 4.6 branch
* Hardware required: TRUE
* Management Server + MySQL on CentOS 7.1
* One KVM Host on CentOS 7.1
* Agent + Common RPMs built from source
* Test results
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1151#issuecomment-161291156
Jenkins error is related to this:
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1132#issuecomment-160903184
Ping @abhinandanprateek @borisroman @jburwell @pdion891 and others for
review
---
If your project is set up for it, you can reply to this email and have your
The 4.6.0 announcement is out, please take 5 minutes to promote on social media:
- NASDAQ GlobeNewswire
http://globenewswire.com/news-release/2015/12/01/791835/0/en/The-Apache-Software-Foundation-announces-Apache-CloudStack-v4-6.html
- ASF "Foundation" blog http://s.apache.org/VfP
- @TheASF
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1132#issuecomment-160561489
@sateesh-chodapuneedi this is a real bug for many users as they are not
able to use Windows 2012 templates with vmware/CloudStack, which is why we need
the fix in
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/1138#issuecomment-160719956
LGTM, seams to fix linguistic issues, at least solving few for French.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1138#issuecomment-160720589
Suggested a small french change, but still LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1138#issuecomment-160721861
@remibergsma Fine with me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1138
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1138#discussion_r46184167
--- Diff: client/WEB-INF/classes/resources/messages_fr_FR.properties ---
@@ -1739,7 +1740,7 @@ message.action.enable.nexusVswitch=Confirmer
l\\'activation
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1138#issuecomment-160721455
Thanks for the reviews, I'll merge it to 4.6 like this. The improvement
should go via Transiflex website and ends up in a new PR when @milamberspace
submits
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1121#issuecomment-160559759
LGTM based on the code. I don't see any real issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1121#issuecomment-160574861
Merging now that we're tests performed and 2LGTMs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1121#issuecomment-160576751
great @bhaisaab I'll create the merge forward
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1085#issuecomment-160442363
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1085#issuecomment-160442447
Functionality also works:
```
(local) � > list vlanipranges keyword=50
count = 1
vlaniprange:
id =
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1085
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1132#issuecomment-160443626
@bhaisaab Let's find someone else who can review this..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user milamberspace opened a pull request:
https://github.com/apache/cloudstack/pull/1138
Update L10N resource files with 4.6 strings from Transifex (20151129)
Small update of L10N files before the 4.6.1 release candidate
cc @remibergsma
You can merge this pull
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1136#issuecomment-160418520
@bhaisaab you should not have merged #1119 as it is also in 4.6. This merge
commit was wrong because of this isse and should have been fixed before
merging
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1121#issuecomment-160390678
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1136#issuecomment-160390613
@bhaisaab The problem with your approach, to be honest, is that the commit
ID changed. As this was a bit of a special case it may not be a problem.
General
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1121#issuecomment-160390932
Pinging @DaanHoogland @borisroman to do second review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1121#discussion_r46089169
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -419,7 +419,7 @@ public String toString() {
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1136#issuecomment-160391011
@remibergsma I used the git pr tool so not sure how the commit ID changed,
I merged the other PR because 4.6 merge on master chose the other change while
merge
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1121#discussion_r46089189
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -761,6 +766,10 @@ public String toString() {
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1121#discussion_r46089183
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -419,7 +419,7 @@ public String toString() {
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1132#issuecomment-160392997
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1136#issuecomment-160391149
@bhaisaab The commit ID didn't change from the PR and your merge, that was
fine. It was just different in 4.6 branch because the change was done combined
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1121#discussion_r46089207
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -761,6 +766,10 @@ public String toString() {
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1132#issuecomment-160514080
Thanks @remibergsma
Ping @sateesh-chodapuneedi can you review this, and later if you want sent
additional PRs with further changes etc.
---
If your project
1 - 100 of 602 matches
Mail list logo
