Min,
I’m checking some findbugs reports and found the following piece of code in
VolumeDataStoreVO (line 352):
public void setRefCnt(Long refCnt) {
if (refCnt 0) {
refCnt--;
}
else {
s_logger.warn(We should not try to decrement a zero
Thanks Hugo for pointing that out. That is a bug caused by copy-and-paste,
the code should be in decrRefCnt routine like other SnapshotDataStoreVO
and TemplateDataStoreVO.
I will fix this in a minute.
-min
On 9/3/14 12:30 AM, Hugo Trippaers h...@trippaers.nl wrote:
Min,
I¹m checking some
H Min,
what is this fix for?
On Wed, Sep 3, 2014 at 8:20 PM, Min Chen min.c...@citrix.com wrote:
Fix is checked into master branch. Can I back port it to 4.4?
Thanks
-min
On 9/3/14 9:42 AM, Min Chen min.c...@citrix.com wrote:
Thanks Hugo for pointing that out. That is a bug caused by
Fix is checked into master branch. Can I back port it to 4.4?
Thanks
-min
On 9/3/14 9:42 AM, Min Chen min.c...@citrix.com wrote:
Thanks Hugo for pointing that out. That is a bug caused by copy-and-paste,
the code should be in decrRefCnt routine like other SnapshotDataStoreVO
and
This is a bug that will impact reference counting only for old volume on
NFS to S3 object store migration.
Thanks
-min
On 9/3/14 11:25 AM, Daan Hoogland daan.hoogl...@gmail.com wrote:
H Min,
what is this fix for?
On Wed, Sep 3, 2014 at 8:20 PM, Min Chen min.c...@citrix.com wrote:
Fix is
guess you should go ahead and backport.
On Wed, Sep 3, 2014 at 8:28 PM, Min Chen min.c...@citrix.com wrote:
This is a bug that will impact reference counting only for old volume on
NFS to S3 object store migration.
Thanks
-min
On 9/3/14 11:25 AM, Daan Hoogland daan.hoogl...@gmail.com
Backported to 4.4 branch.
-min
From: Daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com
Date: Wednesday, September 3, 2014 11:52 AM
To: dev dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org, Min Chen
min.c...@citrix.commailto:min.c...@citrix.com
Subject: Re: Commit
