Re: Entity UUID and Type missing on ActionEvent event notifications

ionEvent is right approach. >> >> Thanks, >> Murali >> >> From: David Grizzanti >> Date: Thursday, 12 December 2013 10:16 PM >> To: Murali Reddy , "dev@cloudstack.apache.org" >> , Alex Ough , Nitin >>Mehta >>

Re: Entity UUID and Type missing on ActionEvent event notifications

December 2013 10:16 PM >> To: Murali Reddy , "dev@cloudstack.apache.org" >> , Alex Ough , Nitin >>Mehta >> >> Subject: Re: Entity UUID and Type missing on ActionEvent event >>notifications >> >> Murali/All, >> >> Opening this dis

Re: Entity UUID and Type missing on ActionEvent event notifications

16 PM > To: Murali Reddy , "dev@cloudstack.apache.org" > , Alex Ough , Nitin Mehta > > Subject: Re: Entity UUID and Type missing on ActionEvent event notifications > > Murali/All, > > Opening this discussion back up to decide how to approach fixing this. I > l

Re: Entity UUID and Type missing on ActionEvent event notifications

..@citrix.com>> Subject: Re: Entity UUID and Type missing on ActionEvent event notifications Murali/All, Opening this discussion back up to decide how to approach fixing this. I looked over what Nitin mentioned, but given that I don't know a whole lot about the inner working of the co

Re: Entity UUID and Type missing on ActionEvent event notifications

Alex, That may be true for master when UserContext was replaced.  But, on 4.2.0 when UserContext is still in use, the UUIDs are missing. ActionEventUtils does pull the entity uuid and types to send on to the publishOnEventBus, but those variables are never being set to anything in UserContext/

Re: Entity UUID and Type missing on ActionEvent event notifications

David, I'm not sure if this is correct, but wasn't 'UserContext' switched with 'CallContext', which caused the missing UUIDs for Domain/Account/User? And if you see '/server/src/com/cloud/event/ActionEventUtils' class, it accesses 'CallContext' to store the entity uuids and types in 'publishOnEven

Re: Entity UUID and Type missing on ActionEvent event notifications

Murali/All, Opening this discussion back up to decide how to approach fixing this.  I looked over what Nitin mentioned, but given that I don't know a whole lot about the inner working of the code I don't see anywhere that it would make sense to put this logic so that it applies to all API comma

Re: Entity UUID and Type missing on ActionEvent event notifications

On 11/12/13 3:01 AM, "David Grizzanti" wrote: >Murali, > >I spoke with Alex regarding this issue and it appears there may have been >some mix up in what the original intent of the bug was and what actually >got fixed. To me, the idea behind this was to address the bug that the >entity UUID was n

Re: Entity UUID and Type missing on ActionEvent event notifications

Murali, I spoke with Alex regarding this issue and it appears there may have been some mix up in what the original intent of the bug was and what actually got fixed.   To me, the idea behind this was to address the bug that the entity UUID was not getting added to ActionEvents for all resource t

Re: Entity UUID and Type missing on ActionEvent event notifications

I modified the fix to make a little simpler, so can you review it please? I'd like to finalize this as soon as possible to move on with CLOUDSTACK-4992. Thanks Alex Ough On Thu, Dec 5, 2013 at 1:32 PM, Alex Ough wrote: > All, > > I submitted the review request, so please review it and let me kn

Re: Entity UUID and Type missing on ActionEvent event notifications

All, I submitted the review request, so please review it and let me know if there is anything missing/incorrect. Thanks Alex Ough On Wed, Dec 4, 2013 at 11:29 PM, Murali Reddy wrote: > On 05/12/13 12:01 AM, "Alex Ough" wrote: > > >All, > > > >I made a comment on its jira, > >CLOUDSTACK-3190

Re: Entity UUID and Type missing on ActionEvent event notifications

On 05/12/13 12:01 AM, "Alex Ough" wrote: >All, > >I made a comment on its jira, >CLOUDSTACK-3190, >so can anyone confirm what I found? >I guess it is related with some refactoring related with 'CallContext' >class. Alex, Yes, it regressed d

Re: Entity UUID and Type missing on ActionEvent event notifications

All, I made a comment on its jira, CLOUDSTACK-3190, so can anyone confirm what I found? I guess it is related with some refactoring related with 'CallContext' class. If correct, I'd like make changes because it is a blocker of what I'm workin

Re: Entity UUID and Type missing on ActionEvent event notifications

David - CallContext gets created during the entry point of the API. I haven't had the chance to completely investigate but I am hoping that you can push the UUID then or on completion of the API (in case where you are creating the actual resource). See if that works else there is no other way out.

Re: Entity UUID and Type missing on ActionEvent event notifications

Thanks for the feedback and info on the existing bug filed for this. Nitin - I was originally thinking along the lines of what Murali has recently commented (i.e. adding Entity Details in the UserContext in all the places where an Action Event is generated).  The particular case I was using this

Re: Entity UUID and Type missing on ActionEvent event notifications

On 20/11/13 2:15 AM, "David Grizzanti" wrote: >Hi All, > >I noticed that the event messages going to rabbitmq of type "ActionEvent" >are missing any reference to the entity Id/UUID. Was this omission >intentional? Poking through the code, I was able to find that adding the >information on to

Re: Entity UUID and Type missing on ActionEvent event notifications

David - Thanks for taking the initiative, that would be great. Can you please let the community know your strategy for populating the UUID ? I was thinking that CallContext can have the UUID populated by the AsyncJobManager on completion. This would mean you would have to do it at one place only.

Entity UUID and Type missing on ActionEvent event notifications

Hi All, I noticed that the event messages going to rabbitmq of type "ActionEvent" are missing any reference to the entity Id/UUID.  Was this omission intentional?   Poking through the code, I was able to find that adding the information on to the event is fairly straightforward (albeit a bit ted