Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-10 Thread Sanjeev N
@Wilder, forgot to mention, either we should also add template for LXC or skip the test for LXC. On Thu, Dec 10, 2015 at 2:40 PM, Sanjeev N wrote: > @wilder, I am ok with it. You can take it over. > One comment, is ostype "Other PV (64-bit)" valid for other hypervisors > otherthan Xenserver? And

Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-10 Thread Sanjeev N
@wilder, I am ok with it. You can take it over. One comment, is ostype "Other PV (64-bit)" valid for other hypervisors otherthan Xenserver? And vmware template format should be in .ova The one you have mentioned in the Services class won't work. On Thu, Dec 10, 2015 at 2:03 PM, wilderrodrigues wr

Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-08 Thread Sanjeev N
Thanks @michaelandersen, I will take those templates and make the test generic. On Tue, Dec 8, 2015 at 3:35 PM, michaelandersen wrote: > Github user michaelandersen commented on the pull request: > > https://github.com/apache/cloudstack/pull/1156#issuecomment-162837936 > > Gotcha. We cou

Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-08 Thread Sanjeev N
@terbolour, as per the previous logic in the test, it will register xenserver template for any hypervisor other than kvm and vm deployment fails for other hypervisors like vmware,hyper-v and lxc. So I was asking how we should handle this. On Tue, Dec 8, 2015 at 12:44 PM, terbolous wrote: > Githu

Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread Sanjeev N
@michaelandersen, if we want to use that template it only works for kvm. So either we have to skip the tests for other hypervisors or make the similar templates for all other hypervisors as well. On Tue, Dec 8, 2015 at 2:00 AM, michaelandersen wrote: > Github user michaelandersen commented on th