Re: Review PRs: please help!

2015-08-19 Thread Milamber
Hello Wido, PR from me are on the localization and web UI, easy to review ;-) https://github.com/apache/cloudstack/pull/697 https://github.com/apache/cloudstack/pull/699 https://github.com/apache/cloudstack/pull/712 Milamber On 19/08/2015 08:22, Wido den Hollander wrote: Hi, Understood :)

Re: Review PRs: please help!

2015-08-19 Thread Wido den Hollander
Hi, Understood :) I'm trying, but most PRs are VMWare or Xen and I personally don't know anything about that code, so I don't feel good in giving in LGTM on such a PR. This is from my personal view, but I only want to give a LGTM on code I understand. KVM and RBD storage PRs? Happy to review the

Review PRs: please help!

2015-08-18 Thread Remi Bergsma
Hi all, Could you please have a look at the PRs we have waiting [1] and review them? Test it, look at the code or otherwise review them. Add comments, or add a LGTM when you think it’s OK. Even if you review just one PR per day it already helps :-) I’ll keep an eye on them as well and will mer