Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm

2013-06-19 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/#review22110 --- api/src/com/cloud/agent/api/to/VirtualMachineTO.java

Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm

2013-06-19 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/ --- (Updated June 19, 2013, 11 a.m.) Review request for cloudstack, Abhinandan

Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm

2013-06-19 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/#review22145 --- Ship it! Ship It! - Abhinandan Prateek On June 19, 2013, 11

Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm

2013-06-19 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/ --- (Updated June 20, 2013, 5:19 a.m.) Review request for cloudstack, Abhinandan

Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm

2013-06-19 Thread Abhinandan Prateek
On June 20, 2013, 4:42 a.m., Abhinandan Prateek wrote: Ship It! Patch fails: Applying: CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm error: patch failed: setup/db/db/schema-410to420.sql:1857 error: setup/db/db/schema-410to420.sql: patch

Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm

2013-06-19 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/#review22151 --- Commit 7b6b8d7a077478620232ea1ac4ec2304289e8661 in branch

Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm

2013-06-18 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/ --- (Updated June 18, 2013, 7:05 a.m.) Review request for cloudstack, Abhinandan

Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm

2013-06-18 Thread Harikrishna Patnala
On June 17, 2013, 3:12 p.m., Prasanna Santhanam wrote: Since XCP shares the same resource (XcpOssResource-CitrixResourceBase) can the command ScaleVmCommand be implemented for XCP too? Prasanna Santhanam wrote: Any comments about adding the XCP support? Agreed we may have to

Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm

2013-06-18 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/#review22108 --- Try to use final String instead of literals for better

Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm

2013-06-17 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/ --- Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Description

Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm

2013-06-17 Thread Harikrishna Patnala
On June 17, 2013, 3:12 p.m., Prasanna Santhanam wrote: server/src/com/cloud/vm/UserVmManagerImpl.java, line 1818 https://reviews.apache.org/r/11910/diff/1/?file=306800#file306800line1818 can this be made case insensitive? so comparisons can compare as equalIgnoreCase? Hi

Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm

2013-06-17 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/ --- (Updated June 17, 2013, 6:37 p.m.) Review request for cloudstack, Abhinandan

Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm

2013-06-17 Thread Prasanna Santhanam
On June 17, 2013, 3:12 p.m., Prasanna Santhanam wrote: Since XCP shares the same resource (XcpOssResource-CitrixResourceBase) can the command ScaleVmCommand be implemented for XCP too? Any comments about adding the XCP support? On June 17, 2013, 3:12 p.m., Prasanna Santhanam wrote: