On Aug. 5, 2013, 6:17 p.m., edison su wrote:
engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java, line 77
https://reviews.apache.org/r/13237/diff/1/?file=334435#file334435line77
why not just use select s.scope from storage_pool s, volumes v where
s.id = v.pool_id?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/
---
(Updated Aug. 6, 2013, 7:13 p.m.)
Review request for cloudstack, Devdeep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/#review24736
---
Ship it!
Ship It!
- edison su
On Aug. 6, 2013, 7:13 p.m.,
On Aug. 6, 2013, 7:57 p.m., edison su wrote:
Ship It!
thanks for committing the patch
- Rajesh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/#review24736
On Aug. 5, 2013, 6:17 p.m., edison su wrote:
engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java, line 77
https://reviews.apache.org/r/13237/diff/1/?file=334435#file334435line77
why not just use select s.scope from storage_pool s, volumes v where
s.id = v.pool_id?
if we
On Aug. 5, 2013, 6:17 p.m., edison su wrote:
engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java, line 77
https://reviews.apache.org/r/13237/diff/1/?file=334435#file334435line77
why not just use select s.scope from storage_pool s, volumes v where
s.id = v.pool_id?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/#review24653
---
engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/
---
Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.
Bugs:
On Aug. 2, 2013, 11:29 a.m., Jenkins Cloudstack.org wrote:
Review 13237 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #106 is :
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/106/
patch is not generated on master branch hence this failure
