Re: Review Request 14148: Cleanup DefaultUserAuthenticator and removed masking _name variable

2013-09-20 Thread Abhinandan Prateek
On Sept. 19, 2013, 4:20 a.m., Abhinandan Prateek wrote: Ship It! Abhinandan Prateek wrote: when i try to apply the patch git am says Patch format detection failed.. Committed !

Re: Review Request 14148: Cleanup DefaultUserAuthenticator and removed masking _name variable

2013-09-20 Thread Abhinandan Prateek
On Sept. 19, 2013, 4:20 a.m., Abhinandan Prateek wrote: Ship It! Abhinandan Prateek wrote: when i try to apply the patch git am says Patch format detection failed.. Abhinandan Prateek wrote: Committed !

Re: Review Request 14148: Cleanup DefaultUserAuthenticator and removed masking _name variable

2013-09-18 Thread Darren Shepherd
On Sept. 18, 2013, 5:37 a.m., Abhinandan Prateek wrote: In client/tomcatconf/applicationContext.xml.in we are referring passing name properties to the authentication adapters e.g.: bean id=LdapAuthenticator class=org.apache.cloudstack.ldap.LdapAuthenticator property

Re: Review Request 14148: Cleanup DefaultUserAuthenticator and removed masking _name variable

2013-09-18 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14148/#review26261 --- Ship it! Ship It! - Abhinandan Prateek On Sept. 18, 2013, 5:39

Re: Review Request 14148: Cleanup DefaultUserAuthenticator and removed masking _name variable

2013-09-18 Thread Abhinandan Prateek
On Sept. 19, 2013, 4:20 a.m., Abhinandan Prateek wrote: Ship It! when i try to apply the patch git am says Patch format detection failed.. - Abhinandan --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 14148: Cleanup DefaultUserAuthenticator and removed masking _name variable

2013-09-17 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14148/#review26209 --- In client/tomcatconf/applicationContext.xml.in we are referring

Re: Review Request 14148: Cleanup DefaultUserAuthenticator and removed masking _name variable

2013-09-17 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14148/ --- (Updated Sept. 18, 2013, 5:38 a.m.) Review request for cloudstack and

Re: Review Request 14148: Cleanup DefaultUserAuthenticator and removed masking _name variable

2013-09-17 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14148/ --- (Updated Sept. 18, 2013, 5:39 a.m.) Review request for cloudstack, Abhinandan

Review Request 14148: Cleanup DefaultUserAuthenticator and removed masking _name variable

2013-09-16 Thread Darren Shepherd
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14148/ --- Review request for cloudstack and Abhinandan Prateek. Repository: