Re: Review Request 14477: Refactor Storage Related Resource Code

Feel free to close it out, it's in the repo now. I'd love if you were able to think about the test-ability of the changes... and yes, we are missing useful tests and approaches all over the place. On Mon, Oct 7, 2013 at 4:15 PM, SuichII, Christopher wrote: > Thanks for the notes, Edison. > >

Re: Review Request 14477: Refactor Storage Related Resource Code

Thanks for the notes, Edison. Chip - Edison hit all the important points, but I'm not sure what the proper etiquette is here. I'd be more than happy to add some tests, but after looking through the code, I can't find any tests to model after. While I don't mind coming up with a model for testin

Re: Review Request 14477: Refactor Storage Related Resource Code

thanks for the comments, seems fair!

Re: Review Request 14477: Refactor Storage Related Resource Code

> On Oct. 4, 2013, 8:23 p.m., Chip Childers wrote: > > api/src/org/apache/cloudstack/api/command/user/snapshot/RevertSnapshotCmd.java, > > line 36 > > > > > > Are there any unit or integration tests for this new API ca

Re: Review Request 14477: Refactor Storage Related Resource Code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14477/#review26694 --- Some questions and comments that probably need to be answered before

Re: Review Request 14477: Refactor Storage Related Resource Code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14477/#review26693 --- Ship it! Ship It! - edison su On Oct. 4, 2013, 12:57 a.m., Chris

Review Request 14477: Refactor Storage Related Resource Code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14477/ --- Review request for cloudstack. Repository: cloudstack-git Description ---