Re: Review Request 14577: Remove Setters from *JoinVO Classes

2013-10-14 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14577/#review26991 --- Ship it! Ship It! - edison su On Oct. 14, 2013, 1:04 p.m., Chris

Re: Review Request 14577: Remove Setters from *JoinVO Classes

2013-10-14 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14577/ --- (Updated Oct. 14, 2013, 1:04 p.m.) Review request for cloudstack, Koushik Das,

Re: Review Request 14577: Remove Setters from *JoinVO Classes

2013-10-14 Thread SuichII, Christopher
Good idea, Dann - I'll make sure to add some people who responded to the original thread to the reviewer list. Laszio, that is an interesting point. I'm not sure if CS is currently JPA compliant. However, after looking through JSR-317, I can't seem to find anything in the spec about views. Is t

Re: Review Request 14577: Remove Setters from *JoinVO Classes

2013-10-13 Thread Laszlo Hornyak
Hi, I tested it yesterday and it looked like working correctly. My only concern about it is that I am not sure if this is still compatible with standard JPA, However this may not be an important point since CS does not really build on standard JPA. I would be interested in any info in the plans fo

Re: Review Request 14577: Remove Setters from *JoinVO Classes

2013-10-13 Thread Daan Hoogland
Chris, have you been discussing this with anybody? I think you should include those people in the reviewers list to get feedback. I would have to find some time to play around with it, though it looks ok on first glance. regards, Daan On Fri, Oct 11, 2013 at 9:33 PM, SuichII, Christopher wrote:

Re: Review Request 14577: Remove Setters from *JoinVO Classes

2013-10-11 Thread SuichII, Christopher
Just bumping this. It should be a fairly simple review. -- Chris Suich chris.su...@netapp.com NetApp Software Engineer Data Center Platforms – Cloud Solutions Citrix, Cisco & Red Hat On Oct 10, 2013, at 1:04 PM, Chris Suich mailto:chris.su...@netapp.com>> wrote: T

Review Request 14577: Remove Setters from *JoinVO Classes

2013-10-10 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14577/ --- Review request for cloudstack. Repository: cloudstack-git Description ---