Re: Review Request 17113: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500

2014-01-21 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17113/#review32476 --- Commit 939327561192eba7f21f6d5acb0119278984b510 in branch

Re: Review Request 17113: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500

2014-01-21 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17113/#review32477 --- Commit 939327561192eba7f21f6d5acb0119278984b510 in branch

Re: Review Request 17113: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500

2014-01-20 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17113/ --- (Updated Jan. 20, 2014, 8:42 a.m.) Review request for cloudstack and Girish

Re: Review Request 17113: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500

2014-01-20 Thread Sebastien Goasguen
- Sebastien --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17113/#review32283 --- On Jan. 20, 2014, 8:42 a.m., Santhosh Edukulla

Re: Review Request 17113: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500

2014-01-20 Thread Sebastien Goasguen
On Jan. 20, 2014, 7:51 a.m., Girish Shilamkar wrote: Moving forward, could you please organise commits/patches in discrete functional units. So that it is easier to review the change. Thanks ! Yes, I recommend one patch per bug fixed. - Sebastien

Re: Review Request 17113: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500

2014-01-20 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17113/#review32287 --- Santhosh, I have already committed the orignal patch. Can you

Review Request 17113: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500

2014-01-19 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17113/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5498,

Re: Review Request 17113: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500

2014-01-19 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17113/ --- (Updated Jan. 20, 2014, 6:36 a.m.) Review request for cloudstack and Girish

Re: Review Request 17113: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500

2014-01-19 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17113/ --- (Updated Jan. 20, 2014, 6:36 a.m.) Review request for cloudstack and Girish

Re: Review Request 17113: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500

2014-01-19 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17113/#review32283 --- Ship it! Moving forward, could you please organise commits/patches