Re: Review Request 19039: CLOUDSTACK-2266: Adding automation tests for IP reservation feature

2014-04-01 Thread Santhosh Edukulla
On March 21, 2014, 6:50 a.m., Santhosh Edukulla wrote: Ship It! It seems all review items have been addressed. We can just commit it. - Santhosh --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 19039: CLOUDSTACK-2266: Adding automation tests for IP reservation feature

2014-04-01 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19039/#review39232 --- Commit 15aeaf25dee0a0182121976bf0db62a16321d386 in cloudstack's

Re: Review Request 19039: CLOUDSTACK-2266: Adding automation tests for IP reservation feature

2014-04-01 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19039/#review39234 --- Commit ca1b911a4f1fba55a39322bce3eec009bf4b6269 in cloudstack's

Re: Review Request 19039: CLOUDSTACK-2266: Adding automation tests for IP reservation feature

2014-03-21 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19039/#review38068 --- Ship it! Ship It! - Santhosh Edukulla On March 20, 2014, 5:31

Re: Review Request 19039: CLOUDSTACK-2266: Adding automation tests for IP reservation feature

2014-03-20 Thread Ashutosh Kelkar
On March 18, 2014, 6:57 a.m., Santhosh Edukulla wrote: test/integration/component/test_ip_reservation.py, line 258 https://reviews.apache.org/r/19039/diff/3/?file=519653#file519653line258 Move this to a utility function i believe. Also, do we have a class in base.py for Router to

Re: Review Request 19039: CLOUDSTACK-2266: Adding automation tests for IP reservation feature

2014-03-20 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19039/ --- (Updated March 20, 2014, 5:31 p.m.) Review request for cloudstack, Santhosh

Re: Review Request 19039: CLOUDSTACK-2266: Adding automation tests for IP reservation feature

2014-03-18 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19039/#review37538 --- test/integration/component/test_ip_reservation.py

Re: Review Request 19039: CLOUDSTACK-2266: Adding automation tests for IP reservation feature

2014-03-14 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19039/ --- (Updated March 14, 2014, 4:44 p.m.) Review request for cloudstack, Santhosh

Review Request 19039: CLOUDSTACK-2266: Adding automation tests for IP reservation feature

2014-03-12 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19039/ --- Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.