Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py

2014-06-05 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/#review44801 --- Commit 96272f4cde4e1012da820264ff91c43a9ec255c4 in cloudstack's

Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py

2014-06-04 Thread Ashutosh Kelkar
On June 3, 2014, 12:27 p.m., Santhosh Edukulla wrote: test/integration/smoke/test_non_contigiousvlan.py, line 47 https://reviews.apache.org/r/22197/diff/2/?file=602802#file602802line47 As well, can we run these changes once and see no issues if its possible? Yes I did run it

Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py

2014-06-04 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/#review44702 --- Ship it! Ship It! - Santhosh Edukulla On June 3, 2014, 11:45

Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py

2014-06-04 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/#review44800 --- Commit 81bf37f33853d95e7c4137d57a60e719963913c4 in cloudstack's

Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py

2014-06-03 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/ --- Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. Bugs:

Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py

2014-06-03 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/#review44612 --- test/integration/smoke/test_non_contigiousvlan.py

Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py

2014-06-03 Thread Ashutosh Kelkar
On June 3, 2014, 11:22 a.m., Santhosh Edukulla wrote: test/integration/smoke/test_non_contigiousvlan.py, line 29 https://reviews.apache.org/r/22197/diff/1/?file=602789#file602789line29 Is it ok to move to test data? Removed services dictionary as it is no longer used - Ashutosh

Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py

2014-06-03 Thread Ashutosh Kelkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/ --- (Updated June 3, 2014, 11:45 a.m.) Review request for cloudstack, Girish

Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py

2014-06-03 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/#review44616 --- test/integration/smoke/test_non_contigiousvlan.py